Closed
Bug 573739
Opened 14 years ago
Closed 14 years ago
Don't get the private browsing service during layout module initialization
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
3.86 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
A few places are trying to get the private browsing service during layout module initialization. This isn't a good idea, because it can cause recursive entry into the layout module (which also contains xpconnect), and it's also unnecessary because private browsing won't really know what's going on until the profile is loaded anyway. This patch defers private-browser checking until profile-after-change.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #453084 -
Flags: review?(ehsan)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 453084 [details] [diff] [review] Get the service later, rev. 1 Makes sense. r=me.
Attachment #453084 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/648ae11bf9e0
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•