Advanced->Reading & Display->Close message window on delete pref text incomplete

RESOLVED FIXED in Thunderbird 3.3a1

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mdudziak, Assigned: mdudziak)

Tracking

Trunk
Thunderbird 3.3a1
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
The problem is that the preference 'Advanced->Reading & Display->Close message window on delete' does not indicate that this also happens when messages are moved.

Label should be updated to reflect that this applies to moving messages as well.
(Assignee)

Comment 1

8 years ago
Created attachment 453107 [details] [diff] [review]
Patch that changes the label to reflect move as well as delete
Attachment #453107 - Flags: superreview?
Attachment #453107 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #453107 - Flags: superreview?(neil)
Attachment #453107 - Flags: superreview?
Attachment #453107 - Flags: review?(bugmail)
Attachment #453107 - Flags: review?
Comment on attachment 453107 [details] [diff] [review]
Patch that changes the label to reflect move as well as delete

>-<!ENTITY closeMsgWindowOnDelete.label  "Close message window on delete">
>+<!ENTITY closeMsgWindowOnDelete.label  "Close message window on move or delete">

If you're changing the context of a string, then you need to change the name of the string as well (e.g. make it closeMsgWindowOnDelete2.label, or even better closeMsgWindowOnMoveOrDelete.label).

Also as this is mail/ specific code, you just need review from one peer, and as it is touching the UI, a ui-review from clarkbw.
Attachment #453107 - Flags: ui-review?(clarkbw)
Attachment #453107 - Flags: superreview?(neil)
Attachment #453107 - Flags: review?(bugmail)
Attachment #453107 - Flags: review-
(Assignee)

Comment 3

8 years ago
Created attachment 453128 [details] [diff] [review]
Updated patch that changes the String name as well
Attachment #453107 - Attachment is obsolete: true
Attachment #453128 - Flags: ui-review?(clarkbw)
Attachment #453128 - Flags: review?
Attachment #453107 - Flags: ui-review?(clarkbw)
(Assignee)

Updated

8 years ago
Attachment #453128 - Flags: review? → review?(bugmail)
Comment on attachment 453128 [details] [diff] [review]
Updated patch that changes the String name as well

Looks good, thanks.
Attachment #453128 - Flags: ui-review?(clarkbw) → ui-review+
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

8 years ago
Marked as fixed, but still waiting on review from bugmail@asutherland.org
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #5)
> Marked as fixed, but still waiting on review from bugmail@asutherland.org

why did you mark it fixed then ?
Attachment #453128 - Flags: review?(bugmail) → review+
string change, can only land on trunk.
Keywords: checkin-needed
Version: 3.0 → Trunk
Checked in: http://hg.mozilla.org/comm-central/rev/c44e03e75804
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1

Comment 9

8 years ago
Hm, wouldn't it make the life of the localizers a lot easier if the name of the accesskey gets aligned to the new name of the label? At the moment the name of the label and the corresponding accesskey are now unequal.
You need to log in before you can comment on or make changes to this bug.