573858 - changing an addon's name does not take effect until revision is saved

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect, P3)

Description

[Dietrich Ayala (:dietrich)]

1. clicking on your addon's name on the left side
2. change the title in the dialog
3. click ok to close the dialog

the displayed name is not changed. if you open the dialog the change does show up there. but if you reload the page, the changes are completely lost.

i think this should block, so we don't end up with a zillion "My Addon" addons.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

It looks like changes to the Name and Description fields only take effect when you press the Save button.  Since those changes are not versioned, and the Save button is for saving changes that are versioned (which is why pressing the Save button creates a new revision), changes to the Name and Description fields should indeed take effect immediately.

I'm not sure this should block.  It sucks, but does it suck enough to rise to the level of a blocker (as opposed to something we should document in a release note) for this early preview?

Comment 2

[Dietrich Ayala (:dietrich)]

The reason i thought it should block is because the "first impression" experience of Flightdeck: a bunch of "My Addon" addons. Not so exciting. Since this isn't public beta, yeah probably doesn't have to block.

WRT to a solution: I didn't get at all that it was tied to hitting save. I thought that those buttons were all about the code, since they're visually differentiated in the UI (different section, different look), and the addon info bit is in it's own dialog.

I'd prefer that the addon info fields apply when you hit "ok". If we do decide to keep it tied to the save button, then we should 1) unify those UI bits and 2) warn when the user makes changes and tries to leave the page without saving them.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #2)
> The reason i thought it should block is because the "first impression"
> experience of Flightdeck: a bunch of "My Addon" addons. Not so exciting. Since
> this isn't public beta, yeah probably doesn't have to block.

Yeah, I'm undecided.  It's quite the pitfall.


> WRT to a solution: I didn't get at all that it was tied to hitting save. I
> thought that those buttons were all about the code, since they're visually
> differentiated in the UI (different section, different look), and the addon
> info bit is in it's own dialog.

Yes, your impression is actually correct with regard to the Name and Description, which are not associated with revisions (i.e. they are not versioned) and shouldn't have to be saved (instead, changes to them should take effect immediately).

The Version field is the one exception in the Edit Info dialog, since a change in the value of the Version field is associated with the next saved revision.  Piotr and I spent some time figuring out how that should work, and I think it works ok as it is, since if you don't press Save, the code changes to which the new version applies aren't saved either.

But it makes me wonder whether a change to the Version field should prompt an immediate save.  Alternately, as you suggest, we could integrate the Version field into the Save button.  I've mocked up an enhanced Save button with a dropdown marker for opening a popup that lets you specify a changelog comment, and we could probably integrate Version into that popup fairly easily.

And we should indeed warn users when they try to leave the page without saving changes.  We're currently prevented from doing that by a bug in the version of Bespin we are using that prevents us from finding out if the code has changed.  That's again something we'll want to fix for the next release.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Just for the record, there are now 20 pages or so of "My Addon" addons listed.

Comment 5

[Dietrich Ayala (:dietrich)]

let's fix name and description here, and move the redesign of the version/revision stuff and the warn-on-change issue to other bugs. i'll file those.

Comment 6

[Dietrich Ayala (:dietrich)]

filed bug 577736 for moving Version over to the save/revision area.

filed bug 577735 for warning the user when leaving the page without saving changes.

Comment 8

[Dietrich Ayala (:dietrich)]

Not stoked on downgrading severity of this bug. See comment #2 and comment #4. Paging through thousands of My Addon and My Library doesn't make a very good first impression of the site, and makes finding things impossible.

Comment 9

[Daniel Buchner [:dbuc]]

Dietrich! Buddy! I didn't want you to be all frowny faced about this bug, so at the same time I downgraded the severity, I also marked it for completion in this release cycle (we freeze the 15th of November) so take heart! :)

Comment 10

[Dietrich Ayala (:dietrich)]

You've turned my frown upside down.

Comment 11

[Daniel Buchner [:dbuc]]

We will flag unsaved state with a color change on the save button to indicate that a save action is needed from the user.

Comment 12

[Daniel Buchner [:dbuc]]

As a more robust solution, let's get the AMO username of the developer and save unnamed add-ons with this as the title then increment that so mine would be Dandonkulous, Dandonkulous(2), etc. This way unmodified packages are not flooding the page with the same names.

Comment 13

[Andy McKay]

https://github.com/andymckay/FlightDeck/commit/c6d4762a39b4cb9d62f8b0d4b21f40a7082e6ed7