573890 - Narcissus JS: replace __defineProperty__

Status: RESOLVED DUPLICATE of bug 546532

(Core :: JavaScript Engine, defect)

Description

[Tom Austin]

Currently __defineProperty__ is being used heavily within Firefox, which is not available in the standard build.  For the most part, it seems safe to replace this function with Object.defineProperty.

I've attempted to do this, but I have run into challenges for cases where dontDelete (the first boolean parameter to __defineProperty__) was set to true.  I attempted to resolve this by setting configurable=false, but this does not seem to work.  280 additional unit tests fail.

Comment 1

[Brendan Eich [:brendan]]

Tom, I typed narcissus into bugzilla's quicksearch textbox (at top and bottom of every page) and saw a bunch of open bugs, including bug 546532 filed by Andreas, with a patch. Dup'ing this bug to that since it was first and with a patch (we sometimes "dup forward" if the newer bug has more info).

I don't know whether narcissus with bug 546532 patched failed the same tests you saw, but configurable: false is the new dontDelete: true. Let's talk and update results over in bug 546532.

/be