Closed Bug 573902 Opened 9 years ago Closed 9 years ago

Remove any panning and zooming code that doesn't work in e10s

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Current panning code tries to pan HTML and XUL content from the main process, which doesn't work in e10s. The code will need to be migrated to the content process somehow. Or be handled by Layers when it lands.

We can pan the main page area via the chrome-side scrollbox.

The current code also tries to zoom on an element, in content. This also doesn't work. We can zoom in arbitrary steps and using the double-tap fallback of 2X.

This patch removes any code that is no longer needed to support panning frames. The patch also removes any "zoom to element" code. This includes the chrome-side ElementTouchHelper and Browser.elementFromPoint and some others.
Attachment #453284 - Flags: review?(21)
Attachment #453284 - Flags: review?(mbrubeck)
I have start a very similar patch on my side yesterday (I should have upload a wip), but I'm trying to keep as much functionalities as possible (removing Browser.elementFromPoint breaks context menu too).

So basically my patch remove the same things but I'm thinkink of sending back information from content on the element above the mousedown as we do for highlighting but with enought information than we can keep context menu and dblclick.

I'm still not sure of the right way of some zooming cases but I want to investigate this way before fully reviewing this patch.
As seen on IRC, let keep this patch but with messages to keep the Zoom/ContextMenu funcs.
Attachment #453284 - Flags: review?(mbrubeck) → review+
Attachment #453284 - Flags: review?(21)
pushed:
http://hg.mozilla.org/mobile-browser/rev/cdfed9c4e662
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.