Open Bug 574005 Opened 9 years ago Updated 11 months ago

Make obtaining CF_HTML directly work on Windows and Linux (application/x-moz-nativehtml)

Categories

(Core :: Editor, defect)

defect
Not set

Tracking

()

People

(Reporter: ehsan, Unassigned)

References

Details

Attachments

(1 file)

See bug 572642 comment 15 through 25.
Assignee: nobody → netzen
Summary: Make the CF_HTML handling test work on Windows and Linux as well → Make obtaining CF_HTML directly work on Windows and Linux (application/x-moz-nativehtml)
Blocks: 598289
Comment on attachment 553884 [details] [diff] [review]
Patch for Make obtaining CF_HTML directly for Windows and Linux (application/x-moz-nativehtml)

Didn't know that this is going to be this easy! :)
Attachment #553884 - Flags: review?(ehsan) → review+
Thanks for the quick reviews :)
How have you tested this patch?
Only on Windows but I'll run it through the try server for sure once I get to this patch in my try-queue.
(In reply to comment #5)
> Only on Windows but I'll run it through the try server for sure once I get to
> this patch in my try-queue.

No, I meant, what specifically have you tested on Windows?  With what target applications?
I don't think this code is hit unless you specifically use application/x-moz-nativehtml.  

Normal copy/pasting of HTML gives you text/html. 

So the only way I know how to test this is via the mochitest.
Ditto if you copy from Firefox and paste to a different program like Google Chrome it will go into CreateDataFromPrimitive with text/html.
Well, land away then!  :-)
This fell through the cracks too!

https://bug574005.bugzilla.mozilla.org/attachment.cgi?id=553884
Flags: in-testsuite+
Target Milestone: --- → mozilla9
I think there was a problem with this on Linux still
Caused linux M3 orange:
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1315868342.1315869595.15746.gz
{
11145 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-firefox.txt should be successful in contenteditable - didn't expect -1, but got it
11146 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-firefox.txt should be successful in designMode - didn't expect -1, but got it
11147 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-ooo.txt should be successful in contenteditable - didn't expect -1, but got it
11148 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-ooo.txt should be successful in designMode - didn't expect -1, but got it
11149 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-ie.txt should be successful in contenteditable - didn't expect -1, but got it
11150 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-ie.txt should be successful in designMode - didn't expect -1, but got it
11151 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-chromium.txt should be successful in contenteditable - didn't expect -1, but got it
11152 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-chromium.txt should be successful in designMode - didn't expect -1, but got it
}
Actually I don't think there's a problem with the patch I just think we can only eanble Windows in test_CF_HTML_clipboard.html in the context of this ticket (Windows and Linux had the test disabled).  

I think I will be posting another ticket relating to whatever the second problem is on Linux.
Backed out of inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/90a54cb7f985
Status: NEW → ASSIGNED
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: mozilla9 → ---
Assignee: netzen → nobody
No assignee, updating the status.
Status: ASSIGNED → NEW
No assignee, updating the status.
No assignee, updating the status.
You need to log in before you can comment on or make changes to this bug.