574029 - The red star besides the "Component" label in show_bug.cgi has no meaning

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

It should go away. I don't see what it means. This is confusing.

Comment 1

[Tiago Mello [:timello]]

Indeed. The required field indication for the component is useless since there is no way to unset the component to something invalid.

Comment 2

[Tiago Mello [:timello]]

Attachment: Small fix.

So now, we have to use the template parameter 'mandatory' in order to differ enter_bug from show_bug, in that way, we can have such granularity.

Comment 3

[Frédéric Buclin]

Comment on attachment 453433 [details] [diff] [review]
Small fix.

>=== modified file 'template/en/default/bug/field.html.tmpl'

>+[% IF !mandatory %]
>+  [% mandatory = field.is_mandatory %]
>+[% END %]

You can never pass mandatory = 0. Also, why haven't the product and version fields the is_mandatory attribute set to true? They are mandatory when calling Bug.create, isn't it?

Comment 4

[Max Kanat-Alexander]

Comment on attachment 453433 [details] [diff] [review]
Small fix.

The "required" star should never show up on show_bug.cgi for *any* field.

We should not be removing is_mandatory from the component field in the database, and we shouldn't be changing the API of field.html.tmpl to fix this.

Comment 5

[Tiago Mello [:timello]]

Attachment: Fix.

I needed to do the same [% IF NOT bug.id %] in the field-label, because this template is called alone as well.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 453487 [details] [diff] [review]
Fix.

Cool. Simpler, but we don't need "mandatory" as an option to field.html.tmpl anymore.

Also, because of the way TT works, you need an ELSE that sets mandatory = 0.

Comment 7

[Tiago Mello [:timello]]

Attachment: v3

Comment 8

[Max Kanat-Alexander]

Comment on attachment 453491 [details] [diff] [review]
v3

>+  #   mandatory: a boolean specifying whether or not the field is mandatory.

  This actually isn't part of the API, is it?

>+[% IF NOT bug.id %]
>+  [% mandatory = field.is_mandatory %]
>+[% END %]

  If it is part of the API, you're overwriting it here.

  Also, you need an ELSE that sets mandatory = 0 (because TT has no namespaces).

Comment 9

[Tiago Mello [:timello]]

Attachment: v4

I think it could be simpler than everything else I did here before.

Comment 10

[Max Kanat-Alexander]

Comment on attachment 453533 [details] [diff] [review]
v4

Looks great. :-)

Comment 11

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/bug/field-label.html.tmpl
Committed revision 7244.