574033 - HUD Console should evaluate commands in window scope

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Austin King [:ozten]]

My first instinct when using the HUD is to run code that treats the global scope as the content's window.

Repro:
1) Open a console on a page with jQuery included
2) Type $ into the console

Actual:
ReferenceError: $ is not defined

Expected:
Console would log the function and I'd know I could experiment with my page's content...

Workaround:
window.$ does work properly, but without a tooltip many people won't know (or want to) use window explicitly.

Comment 1

[Julian Viereck]

Attachment: [checked-in] Patch

Note: This is not a proper fix for the problem but more a work around (it uses a with(window) { xxx } statement! That's evil, I know...).

This work around shouldn't be necessary anymore after bug 572953 is fixed, which is about dealing with the root of the problem. In the meantime, this is the best/easiest solution.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 457875 [details] [diff] [review]
[checked-in] Patch

i am a-ok with doing this until the platform issue is resolved. r=me.

Comment 3

[David Dahl :ddahl]

you really should add a TODO comment about removing "with" referencing the bug 572953

Comment 4

[Rob Campbell [:rc] (:robcee)]

where was this checked in?

Comment 5

[David Dahl :ddahl]

i don't think it was yet.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 457875 [details] [diff] [review]
[checked-in] Patch

changeset:   47920:8f6215091539
tag:         tip
user:        Julian Viereck <[e-mail]>
date:        Mon Jul 19 10:51:51 2010 -0300
summary:     bug 574033 - HUD Console should evaluate commands in window scope

Comment 7

[[not reading bugmail]]

http://hg.mozilla.org/mozilla-central/rev/8f6215091539