Closed Bug 574071 Opened 10 years ago Closed 10 years ago

Intermittent failure in layout/base/crashtests/348729-1.html | assertion count 0 is less than expected 2 assertions

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b1

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Could be related to the other test run that Ehsan found to not cause this assertion?  See bug 531589 for details.
(In reply to comment #1)
> Could be related to the other test run that Ehsan found to not cause this
> assertion?  See bug 531589 for details.

No, why do you think it has anything to do with that bug?  It's a different test.
Attached patch Patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #453547 - Flags: review?
Attachment #453547 - Flags: review? → review?(jruderman)
Comment on attachment 453547 [details] [diff] [review]
Patch (v1)

I'd prefer making the test deterministic.  Make the timeouts chain rather than race.
Attachment #453547 - Flags: review?(jruderman) → review-
(In reply to comment #4)
> (From update of attachment 453547 [details] [diff] [review])
> I'd prefer making the test deterministic.  Make the timeouts chain rather than
> race.

How does that solve the assertion count problem?
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 453547 [details] [diff] [review] [details])
> > I'd prefer making the test deterministic.  Make the timeouts chain rather than
> > race.
> 
> How does that solve the assertion count problem?

Ah, nevermind, I'm just silly.  Updated patch forthcoming.
Attached patch Patch (v2)Splinter Review
Attachment #453547 - Attachment is obsolete: true
Attachment #453562 - Flags: review?(jruderman)
Comment on attachment 453562 [details] [diff] [review]
Patch (v2)

Looks good.  Hopefully it's ok to not have a timeout between removestyles and removing reftest-wait.
Attachment #453562 - Flags: review?(jruderman) → review+
It seems to be OK, AFAICT.
http://hg.mozilla.org/mozilla-central/rev/ae5c51c2ca9a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.