574071 - Intermittent failure in layout/base/crashtests/348729-1.html | assertion count 0 is less than expected 2 assertions

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[(no longer active)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1277316072.1277317760.16451.gz

Comment 1

[cmtalbert]

Could be related to the other test run that Ehsan found to not cause this assertion?  See bug 531589 for details.

Comment 2

[(no longer active)]

(In reply to comment #1)
> Could be related to the other test run that Ehsan found to not cause this
> assertion?  See bug 531589 for details.

No, why do you think it has anything to do with that bug?  It's a different test.

Comment 3

[(no longer active)]

Attachment: Patch (v1)

Comment 4

[Jesse Ruderman]

Comment on attachment 453547 [details] [diff] [review]
Patch (v1)

I'd prefer making the test deterministic.  Make the timeouts chain rather than race.

Comment 5

[(no longer active)]

(In reply to comment #4)
> (From update of attachment 453547 [details] [diff] [review])
> I'd prefer making the test deterministic.  Make the timeouts chain rather than
> race.

How does that solve the assertion count problem?

Comment 6

[(no longer active)]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 453547 [details] [diff] [review] [details])
> > I'd prefer making the test deterministic.  Make the timeouts chain rather than
> > race.
> 
> How does that solve the assertion count problem?

Ah, nevermind, I'm just silly.  Updated patch forthcoming.

Comment 7

[(no longer active)]

Attachment: Patch (v2)

Comment 8

[Jesse Ruderman]

Comment on attachment 453562 [details] [diff] [review]
Patch (v2)

Looks good.  Hopefully it's ok to not have a timeout between removestyles and removing reftest-wait.

Comment 9

[(no longer active)]

It seems to be OK, AFAICT.

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/ae5c51c2ca9a