Closed Bug 574125 Opened 15 years ago Closed 15 years ago

TEST FAILED: test-legacy-nsjetpack.runLegacyTests (empty test)

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ashah, Assigned: adw)

Details

Attachments

(2 files)

Attached file log
Downloaded the jetpack-sdk-latest.zip and ran cfx testall --binary /Users/tchung/Desktop/trunk/Minefield.app/Contents/MacOS/firefox-bin Result - FAIL. see attached log. Same tests pass on Firefox. Minefield Version - Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a6pre) Gecko/20100622 Minefield/3.7a6pre
There are two failures here. The first is: error: TEST FAILED: test-legacy-nsjetpack.runLegacyTests (empty test) The second is: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://browser/content/places/placesOverlay.xul :: <TOP_LEVEL> :: line 25"  data: no]"] Morphing this bug to the first. Will file new bug for the second.
OS: Mac OS X → All
Hardware: x86 → All
Summary: cfx testall --binary fails on minefield → TEST FAILED: test-legacy-nsjetpack.runLegacyTests (empty test)
Version: unspecified → Trunk
Attached patch patchSplinter Review
The two test suites in the nsjetpack package don't actually execute any tests if the binary component isn't available. Since empty tests imply failure, they should do a simple test.pass() in that case.
Attachment #453520 - Flags: review?(avarma)
(In reply to comment #1) > Will file new bug for the second. bug 574184
Comment on attachment 453520 [details] [diff] [review] patch Looks good.
Attachment #453520 - Flags: review?(avarma) → review+
Assignee: nobody → adw
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: -- → 0.6
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product. To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: