"All Versions" page shows new version pending review as if it were public

VERIFIED FIXED in 5.11.3

Status

addons.mozilla.org Graveyard
Public Pages
P2
major
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: jorgev, Assigned: jbalogh)

Tracking

unspecified
5.11.3

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
I uploaded Fire.fm 1.4.6 just a few minutes ago. Now I'm looking at the "All Versions" page, and this new version appears as if it had been already approved, which it hasn't.

Clicking on the button triggers the install with no warning, and judging by other versions in the same page, this only happens for versions in the "pending review" state. I tried this with a few add-ons in the review queue and the same thing happened for all of them.
(Assignee)

Comment 1

8 years ago
VALID_STATUSES = (STATUS_UNREVIEWED, STATUS_PENDING, STATUS_NOMINATED,
                  STATUS_PUBLIC, STATUS_LISTED, STATUS_BETA)

Should anything that isn't public or listed fall into the unreviewed bucket?
Assignee: nobody → jbalogh
(Reporter)

Comment 2

8 years ago
I would think so, yes.
(Assignee)

Comment 3

8 years ago
http://github.com/jbalogh/zamboni/commits/b8966a0
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Created attachment 454590 [details]
My test add-on's pending-review status
Created attachment 454591 [details]
Post-fix screenshot

Looks like it gets the same status as the unreviewed, etc. add-ons
Verified FIXED on https://next.addons.mozilla.org/en-US/firefox/addon/9331/versions/
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.