574241 - "All Versions" page shows new version pending review as if it were public

Status: VERIFIED FIXED

Description

[Jorge Villalobos [:jorgev]]

I uploaded Fire.fm 1.4.6 just a few minutes ago. Now I'm looking at the "All Versions" page, and this new version appears as if it had been already approved, which it hasn't.

Clicking on the button triggers the install with no warning, and judging by other versions in the same page, this only happens for versions in the "pending review" state. I tried this with a few add-ons in the review queue and the same thing happened for all of them.

Comment 1

[Jeff Balogh (:jbalogh)]

VALID_STATUSES = (STATUS_UNREVIEWED, STATUS_PENDING, STATUS_NOMINATED,
                  STATUS_PUBLIC, STATUS_LISTED, STATUS_BETA)

Should anything that isn't public or listed fall into the unreviewed bucket?

Comment 2

[Jorge Villalobos [:jorgev]]

I would think so, yes.

Comment 3

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commits/b8966a0

Comment 4

[Stephen Donner [:stephend]]

Created attachment 454590 [details]
My test add-on's pending-review status

Comment 5

[Stephen Donner [:stephend]]

Created attachment 454591 [details]
Post-fix screenshot

Looks like it gets the same status as the unreviewed, etc. add-ons

Comment 6

[Stephen Donner [:stephend]]

Verified FIXED on https://next.addons.mozilla.org/en-US/firefox/addon/9331/versions/