574273 - [EB] Implement new "Add to mobile" buttons

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Collections, defect, P1)

Description

[Wil Clouser [:clouserw]]

Electric bandwagon supports a special one-per-user collection for mobile add-ons.  See "Type-specific Mobile Collections" in the spec for more details: https://docs.google.com/Doc?docid=0Acwo2Bn17-PrZGZudHRobnJfNjVjYnFqMm5kZw&hl=en


This bug includes:
- Complete development of new mobile buttons
- modification of detection JS to serve mobile buttons on /mobile/ pages
- Please keep the smorgasbord up to date with new buttons

Comment 1

[Jeff Balogh (:jbalogh)]

* Does /mobile/ on Mobile get "Add to Firefox"?
* How do I know if they have the Collector?
* What happens when I click "What is Add to Mobile"?

Comment 2

[Justin Scott [:fligtar]]

(In reply to comment #1)
> * Does /mobile/ on Mobile get "Add to Firefox"?

No

> * How do I know if they have the Collector?

You don't right now. I didn't realize the mocks had different states. For now, let's have the pop-up text be "This add-on will be installed on your device next time you sync using [Add-on Collector]" (goes to collector landing page

> * What happens when I click "What is Add to Mobile"?

It goes to the FAQ question that I'll add. Please make it faq#add-to-mobile

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> (In reply to comment #1)
> > * Does /mobile/ on Mobile get "Add to Firefox"?
> 
> No

Please elaborate.  /mobile/ is going to always add to a collection?

* "Download to desktop" sounds like '90s terminology.

Comment 4

[Justin Scott [:fligtar]]

Mobile on /mobile has normal Add to Firefox buttons so that someone using a mobile device can install the add-on directly

Desktop on /mobile has Add to Mobile buttons that add to the mobile collection.

Comment 5

[Wil Clouser [:clouserw]]

Potch said he can look at this if you can do any backend work that needs to happen.  He'll probably bug you for tips and tricks about buttons.

Comment 6

[Jeff Balogh (:jbalogh)]

potch: I can handle Add vs. Added on the backend.

Comment 7

[Jeff Balogh (:jbalogh)]

I did something in http://github.com/jbalogh/zamboni/commit/1f1af4d.

Issues:
* I'm using <button> instead of <a.button> since we need to submit a form.  The <button> has extra padding.
* The mobile button needs to hide if we're on a mobile browser (z.browser.mobile). The Download button needs to turn into "Download to Desktop" if we're in Firefox.
* The unreviewed popups get in the way of submitting the form.  The popups expect to trigger other .button links, but now we need to trigger a form submission.
* I don't know what will happen when "Download Now" turns into "Download to Desktop" as far as InstallTrigger goes.

Comment 9

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/