574283 - [EB] Implement new "Favorite Collections" page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P1)

Description

[Wil Clouser [:clouserw]]

Compared to the rest of these pages, this is a cake walk.  Mockup is here:  http://people.mozilla.com/~chowse/drop/amo/electric-bandwagon/v1/Favorite_Collection.png

Just a simple listing of add-ons that are in the user's favorites collection.  See "Type-specific: Favorite Collections" in the spec for more details: https://docs.google.com/Doc?docid=0Acwo2Bn17-PrZGZudHRobnJfNjVjYnFqMm5kZw&hl=en

Comment 1

[Jeff Balogh (:jbalogh)]

fligtar: What is the text when /favorites is a public collection?  (And if you have the private text, it's much nicer for me to copy/paste than pull it from the image)

chowse: Please reconcile the Favorites mock with http://people.mozilla.com/~chowse/drop/amo/electric-bandwagon/v1/Collection_Listing.png.  Are all the pieces missing because it's private?

Where can I get the heart icon for the collection?

Comment 2

[Justin Scott [:fligtar]]

Private:
Add-ons that you mark as favorites using the Add to Favorites feature appear below. This collection is currently private, which means only you can see it. If you would like everyone to be able to see your favorites, click the button below to make it public.

Public:
Add-ons that you mark as favorites using the Add to Favorites feature appear below. This collection is currently public, which means everyone can see it. If you would like to hide it from public view, click the button below to make it private.

Comment 3

[Jeff Balogh (:jbalogh)]

Do we only show this big privacy button for favorites collections?

Comment 4

[Justin Scott [:fligtar]]

(In reply to comment #3)
> Do we only show this big privacy button for favorites collections?

ya

Comment 5

[Jeff Balogh (:jbalogh)]

(In reply to comment #4)
> (In reply to comment #3)
> > Do we only show this big privacy button for favorites collections?
> 
> ya

Why don't we show a consistent UI for all collections?

Comment 6

[Justin Scott [:fligtar]]

Favorites collections are different from normal collections in that:
* The description is static text
* There is a Make this Collection Public/Private button
* Description for private favorites is in comment #2
* Description for public favorites if the owner is logged in and viewing is in comment #2
* Description for public favorites for all other users is whatever the real description is, which defaults to: "My favorite add-ons"

Private collections are different from public collections in that:
* The share option is removed
* Watcher count is removed
* Ratings are removed
* Statistics link is removed

Comment 7

[Jeff Balogh (:jbalogh)]

(In reply to comment #6)
> Favorites collections are different from normal collections in that:
> * The description is static text

What if the user sets a description?  Do we drop the static text?

Comment 8

[Justin Scott [:fligtar]]

The user's entered description is only displayed when other users view a public collection.

Comment 9

[Jeff Balogh (:jbalogh)]

Where does "Learn about collections" go?

Comment 10

[Justin Scott [:fligtar]]

(In reply to comment #9)
> Where does "Learn about collections" go?

faq#collections

Comment 11

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/1e0a1c6

QA: have fun with comment 6.