Closed
Bug 574320
Opened 14 years ago
Closed 14 years ago
Tweaks to compartments API
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jorendorff, Unassigned)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
11.70 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
Here are the changes I want to make: 1. Move the AutoCrossCompartmentCall utility class from shell/js.cpp to jsapi.h, just like JSAutoRequest. 2. Change JS_SetGlobalObject to initialize both cx->globalObject and cx->compartment. 3. Don't check the compartments in JS_GetPrivate (because that API can be, and in some circumstances must be, used outside of a request). In addition this patch tidies up shell/js.cpp and makes the shell workers in shell/jsworkers.cpp use the new compartment API.
|
Reporter | |
Comment 1•14 years ago
|
||
Attachment #453701 -
Flags: review?(gal)
|
||
Updated•14 years ago
|
Attachment #453701 -
Flags: review?(gal) → review+
|
|
Reporter | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/d7ad923b3ae6
Whiteboard: fixed-in-tracemonkey
|
|
||
Comment 3•14 years ago
|
||
Crash on startup without this. Also, I am not so sure any more SetGlobalObject is a good point to change cx->compartment. Why do we do that? http://hg.mozilla.org/tracemonkey/rev/6cc02636c52a
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d7ad923b3ae6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•