57441 - "View|Set Language/Region>" does not refresh after installing new packs

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect, P3)

Description

[Karl Ove Hufthammer]

When you change themes, you don't have to restart Moz for the changes to take
effect. You shouldn't have to do this for UI language change either (yes, I know
you probably change themes more often than you change UI language). To use a new
langauge, the user has to:

1 Click the langpack.xpi file to install it
2 Restart Mozilla for the new language pack to become available in the Language
and Web Content menu
3 Choose new language
4 Restart Mozilla

Only 1 should be necessary, and *two* restarts should at least *not* be necessary.

Comment 1

[rchen]

Reassigned to ftang.

Comment 2

[Frank Tang]

reassign to tao. Do we plan to do this in the short term ?

Comment 3

[Robert Kaiser]

I assume this bug has actually be splitted into two parts for every of the
current restarts we need.
This bug itself should IMHO deal with the second restart, which will be
eventually harder to resolve (after selecting different locale).
I assume this because the beginning of the original report is comparing with
skin switching, and this should be for the restart at locale _switching_ then.
I opened a second bug for the "first" restart (at locale _installing_) which
should be easier to resolve. see bug 66909.

Comment 4

[tao]

It appears that installing the langpack does not select it for the user's profile.
I'll take a look!

Comment 5

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 6

[tao]

Attachment: part 1: clean up template code

Comment 7

[tao]

Attachment: take out delayed chrome

Comment 8

[tao]

Attachment: take out delayed chrome

Comment 9

[Robert Kaiser]

Tao, which part(s) of the original report do this patches address? I assume the
first restart could go away with that (the one I filed bug 66909 for), right?
What about the second one?

Comment 10

[Chris Waterson]

sr=waterson

Comment 11

[tao]

Hi, Robert:

Yes, the first part: "View|Set Region/Content" will be refreshed with the new 
langpack so users can select it and restart to see the effect.

Comment 12

[Robert Kaiser]

OK, nice. This is a very welcome step...
Perhaps we should clear up what bug is for what issue (and/or file new bugs for
the remaining part) after the patch is checked in...

Comment 13

[Andreas Becker]

changing qa contact to [e-mail].

Comment 14

[Asa Dotzler [:asa]]

Are you still shooting for 0.9 on this? If so please email [e-mail]
with a status on you progress. If not please retarget against a later Milestone.
Thanks.

Comment 15

[tao]

pending review on the proposed patch...

Comment 16

[tao]

push to 0.91. nominated for nsbeta1

Comment 17

[tao]

r=ssu for the chrome attribute changes. pending on r= on the "View" menu template.

Comment 18

[tao]

r=jbetak. thx!

Comment 19

[tao]

part 1 checked in. "View" menu refreshing still needs the part 2.

Comment 20

[tao]

part2 checked in; you should be able to see the "View" menu refreshed after 
langpack installation. You still need to restart Mozilla after switching the 
langpack, though. (this part is more complicate and addressed in 62174)

Close this bug.

Comment 21

[Jon Rubin]

Reopening this, as there is inconsistency in functionality.  Tested this on
WinMe-Ja using 2001-06-18-07-trunk, with the following results:

1) After downloading and installing Japanese or German region pack, neither
appeared as a selection in the View menu until after restarting.
2) After selecting both the German language and region packs at the same time
for download and install, neither appeared in the View menu until after restarting.
3) After selecting the Japan or German language packs separately for download
and install, they appeared in the View menu without a restart.

Note:  All language and region packs always successfully appeared in the View
menu after restarting the browser.

Comment 22

[Jaime Rodriguez, Jr.]

Marking as nsBranch, as I think this might be a regression.

Changing TM = M0.9.2, because we are past M0.9.1.

Comment 23

[Viswanath Ramachandran]

Is tao going to fix this? Is he back from sabbatical? 

Comment 24

[Andreas Becker]

CC msanz and bobj, maybe they can answer who will fix Tao's bugs while he is out.

Comment 25

[Jon Rubin]

cc nhotta

Naoki, please see my comments from 06-21 about the current problems I've seen.

Comment 26

[Asa Dotzler [:asa]]

pushing out. 0.9.2 is done. (querying for this string will get you the list of
the 0.9.2 bugs I moved to 0.9.3)

Comment 27

[Jaime Rodriguez, Jr.]

Nominating for TM0.9.4. 

Vishy/Msanz - We need to identify the engineering team who is repsonsbile for
fixing this one.

Comment 28

[Blake Ross]

Doesn't look like this is getting fixed before the freeze tomorrow night. 
Pushing out a milestone per Jaime.  Please correct if I'm mistaken.

Comment 29

[tao]

"View|Set Language|Region>" is refreshed when I download and install Japanese
langpack but not Japan region pack. Seems to me the UI refreshing is not 
reliable.

Comment 30

[tao]

Let's push this to 0.9.5 since users can do the switch from the Pref dialog.

Comment 31

[Andreas Becker]

mass change, switching qa contact from jonrubin to ruixu.

Comment 32

[msanz]

nsbranch- as per Tao's milestone

Comment 33

[tao]

observation in installing new langpack/region packs

1. region pack: 

   a. "Pref|Appearance|Content Packs" shows new packs right after 
      installation. 
   b. "View|Set Language/Region >" submenu does not show new packs if the submenu
      was opened before the installation. In new Browser window, the new packs 
      always appear in the sub-menu.

2. language pack:

   a. "Pref|Appearance", the "Language" dropdown list always shows new packs.
   b. "View|Set Language/Region >": same behavior with region packs.

Comment 34

[tao]

change summary field to reflect findings.

Comment 35

[bobj]

Based upon the observations noted in Tao's comment, do we need to update
the instructions on the download page or in any dialogs?

Comment 36

[tao]

reassign to new owner ->dbragg

Comment 37

[Jaime Rodriguez, Jr.]

nominating ...

Comment 38

[dbragg]

Fixed when 91721 was checked in.

Comment 39

[Jimmy Uen]

Verified with Mozilla 2002022703