Closed Bug 574443 Opened 14 years ago Closed 14 years ago

Commands and drag & drop stop working when bookmarks menu button moves across toolbars

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b1
Tracking Status
blocking2.0 --- beta1+

People

(Reporter: mozbugz, Assigned: mak)

References

Details

(Keywords: regression)

Attachments

(1 file, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre Firefox/3.6.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre Firefox/3.6.4

Bookmark editing is not working properly with the new widget, drag & drop, deleting, etc.  Drag & drop, it moves the bookmark somewhere else above where you dropped it. Deleting doesn't work at all.  They're maybe more issues, but didn't test everything.

Reproducible: Always



Expected Results:  
Bookmaarks menu should function the same as the bookmark menu
Blocks: 544817
I should note this happens on my same profile from before this build.  On a new profile I don't notice this problem.
Context menu when right-click on bookmark flickers and is not staying 'on' when holding mouse steady. 

Win7 x64 here 

Properties - seems clickable, the menu closes but there is no dialog box appearing.
Status: UNCONFIRMED → NEW
Ever confirmed: true
After going back from a new profile created with this build to my regular profile, D&D works here.. and delete worked but still seeing issues as Jim noted.

Additionally, when hovering over the context menu items, you see the hover color flicker and the widget above also flickers.
The flicking bookmarks panel and context menu are different on a new profile.
taking a look
Assignee: nobody → mak77
Keywords: regression
Repeat Show and Hide "Bookmarks Toolbar",
Right Click on bookmarks/folder and Choose "Properties", Properties dialog does not popup.
Repeat Show and Hide "Bookmarks Toolbar",
Drag & Drop  does not work properly, doropped bookmark go somewhere.
I also noticed the flickering issue is happening while the bookmarks toolbar is closed.. not really while its open.
Summary: Bookmark functionality is not working properly with the new widget, drag & drop, deleting, etc. → Commands and drag & drop stop working when bookmarks menu button moves across toolbars
Attached patch patch v1.0 (obsolete) — Splinter Review
This fixes D&D and commands.

I'm unable to reproduce flickering, btw it looks like another bug (could be related to D2D? ), so please file a new bug for it provided you can give me some step to reproduce the problem.
Attachment #453892 - Flags: review?(dietrich)
(In reply to comment #9)
> I'm unable to reproduce flickering, btw it looks like another bug (could be
> related to D2D? ), so please file a new bug for it provided you can give me
> some step to reproduce the problem.

oh ok, I can see the flickering now, not a blocker though (while this is) so please file a bug and cc me
blocking2.0: --- → beta1+
Attached patch patch v1.1 (obsolete) — Splinter Review
always reboot the view on customizeDone
Attachment #453892 - Attachment is obsolete: true
Attachment #453900 - Flags: review?(dietrich)
Attachment #453892 - Flags: review?(dietrich)
Attachment #453900 - Flags: review?(dietrich) → review+
nit: "reboot" is a strange term to use - how about reset?
Attached patch patch v1.2 (obsolete) — Splinter Review
buy me a dictionary please.
Attachment #453900 - Attachment is obsolete: true
Attached patch patch v1.3Splinter Review
and new eyeglasses.
Attachment #453911 - Attachment is obsolete: true
Landed: http://hg.mozilla.org/mozilla-central/rev/8cc3c45bd0b1
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a6
(In reply to comment #13)
> Created an attachment (id=453911) [details]
> patch v1.2
> 
> buy me a dictionary please.

Ah, don't we all!  

(In reply to comment #10)
> (In reply to comment #9)
> > I'm unable to reproduce flickering, btw it looks like another bug (could be
> > related to D2D? ), so please file a new bug for it provided you can give me
> > some step to reproduce the problem.
> 

Not D2D just normal. 

> oh ok, I can see the flickering now, not a blocker though (while this is) so
> please file a bug and cc me

Filed bug 574508.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: