574467 - Remove nsAddonRepository.js on updates

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Robert Kaiser]

Bug 568728 converted nsAddonRepository.js to a module, I just realized in the 2.1a2 update verification logs that we don't remove it on updates yet, though we should.

Comment 1

[Robert Kaiser]

Attachment: just remove it

Just remove it! :)

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 453861 [details] [diff] [review]
just remove it

>diff --git a/suite/browser/nsBrowserStatusHandler.js b/suite/browser/nsBrowserStatusHandler.js

Not sure what this hunk is doing I assume another patch

>--- a/suite/installer/package-manifest.in

Thanks I noticed this late late last night and was going to investigate today

Comment 3

[Robert Kaiser]

(In reply to comment #2)
> (From update of attachment 453861 [details] [diff] [review])
> >diff --git a/suite/browser/nsBrowserStatusHandler.js b/suite/browser/nsBrowserStatusHandler.js
> 
> Not sure what this hunk is doing I assume another patch

Yes, sorry, somehow bug 570004 made it into this patch.

> >--- a/suite/installer/package-manifest.in
> 
> Thanks I noticed this late late last night and was going to investigate today

Hah! Will land that in a moment :)

Comment 4

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/e4d9b646a966

Comment 5

[Robert Kaiser]

Landed http://hg.mozilla.org/comm-central/rev/e0c779269296 on 2.1a2 relbranch as a build2 ridealong, so already fixed there now.

Comment 6

[Serge Gautherie (:sgautherie)]

Did you miss to add the removed-files.in part?
http://mxr.mozilla.org/comm-central/search?string=nsAddonRepository.js&case=1&find=%2Finstaller%2F

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #6)
> Did you miss to add the removed-files.in part?

Bug 633394 eventually did it...