574477 - Need sys/queue.h in the NDK to support IPC enabled Android builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Michael Wu [:mwu]]

For electrolysis/IPC enabled builds, we'll need sys/queue.h in [NDK-root]/build/platforms/android-[58]/usr/include to build. This file (or at least my copy) happens to be licensed nicely (BSD) and is compiler/machine independent.

Comment 1

[Michael Wu [:mwu]]

FWIW - I hear electrolysis may be merged into m-c very soon, so getting electrolysis builds isn't too important, but getting sys/queue.h in the NDK will be necessary to ensure things continue to build after electrolysis lands.

Comment 2

[Mike Taylor [:bear]]

(In reply to comment #1)
> FWIW - I hear electrolysis may be merged into m-c very soon, so getting
> electrolysis builds isn't too important, but getting sys/queue.h in the NDK
> will be necessary to ensure things continue to build after electrolysis lands.

is this going to happen before the summit or after?

Comment 3

[Michael Wu [:mwu]]

Before. dougt says "hours probably".

Comment 4

[Mike Taylor [:bear]]

Attachment: adjust android-ndk-r4c rpm spec file to use new source zip

Comment 5

[Mike Taylor [:bear]]

Attachment: point centos5 puppet manifests to new android-ndk-r4c rpm

Comment 6

[Mike Taylor [:bear]]

will be testing this in our staging environment after dinner

Comment 7

[[e-mail] (:bhearsum)]

Bear, can you please paste or attach the instructions used to create the Source .zip?

Comment 8

[Mike Taylor [:bear]]

Attachment: instructions on creating the r4c ndk rpm source zip

The attached is the README.txt file included in the source tarball we have on the FTP server to satisfy some of the licensing restrictions.  It includes the steps required to rebuild the zip file used as the rpmbuild source file

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 455168 [details]
instructions on creating the r4c ndk rpm source zip

This is generally OK but you can attach a new version which is more explicit about sys/queue.h. If I had to rebuilt this I'd have no clue where to put it.

Comment 10

[Mike Taylor [:bear]]

(In reply to comment #9)
> (From update of attachment 455168 [details])
> This is generally OK but you can attach a new version which is more explicit
> about sys/queue.h. If I had to rebuilt this I'd have no clue where to put it.

yea, I haven't finished that yet.  I really should be filing a blocking bug for this that says that I need to also update the ftp source tarball...

/me goes to do that

Comment 11

[[e-mail] (:bhearsum)]

Comment on attachment 455025 [details] [diff] [review]
point centos5 puppet manifests to new android-ndk-r4c rpm

changeset:   190:d9879ee34e47

Comment 12

[[e-mail] (:bhearsum)]

Comment on attachment 455022 [details] [diff] [review]
adjust android-ndk-r4c rpm spec file to use new source zip

changeset:   7:d12b879b7268

Comment 13

[Mike Taylor [:bear]]

Attachment: point centos5 puppet manifests to new android-ndk-r4c rpm

Comment 14

[Mike Taylor [:bear]]

Attachment: adjust android-ndk-r4c rpm spec file to use new source zip

Comment 15

[Rail Aliiev [:rail]]

Comment on attachment 455409 [details] [diff] [review]
point centos5 puppet manifests to new android-ndk-r4c rpm

Looks fine

Comment 16

[Rail Aliiev [:rail]]

Comment on attachment 455410 [details] [diff] [review]
adjust android-ndk-r4c rpm spec file to use new source zip

Looks fine

Comment 17

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 455410 [details] [diff] [review]
adjust android-ndk-r4c rpm spec file to use new source zip

http://hg.mozilla.org/build/rpm-sources/rev/a5e78d78b6e2

Comment 18

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 455409 [details] [diff] [review]
point centos5 puppet manifests to new android-ndk-r4c rpm

http://hg.mozilla.org/build/puppet-manifests/rev/9b89c0af7087

Comment 19

[Michael Wu [:mwu]]

this seems pretty well fixed.