574541 - getResourceURI fails to work correctly with files in subdirectories of the add-on

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

We're just appending the path to the add-ons directory which doesn't work for subdirectories.

Would very much like to fix this for beta 1 if possible as it breaks the new version of an API that add-on developers used to use.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This is the patch. Fairly simple, the tests are the bulk of it. Also had to fix the build config to support zipping up subdirectories for the test addons. For uninstalled XPIs I fixed getResourceURI to return a plain URL to the XPI file rather than a broken link to an undefined entry in the XPI.

For both XPI and extracted cases I test that the following files exist and give a correct URI:

install.rdf
icon.png
subdir/subfile.txt

I also test that these don't claim to be present:

missing.txt
subdir/missing.txt

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 453950 [details] [diff] [review]
patch rev 1

Sweet! I didn't verify this works for registry and file pointer installs but I can't think of any reason they wouldn't just work.

Comment 3

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/c13c4f35a17b

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking as verified fixed based on landing and no regression in an automated test.