Several fixes for configure.in and rules.mk

RESOLVED FIXED in mozilla2.0b1

Status

RESOLVED FIXED
9 years ago
10 months ago

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Tracking

Trunk
mozilla2.0b1
x86
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
1) Fix flags for gcc compiler on Solaris
2) Move Sun Studio specific options from rules.mk to configure.in
also add -D__FUNCTION__=__func__ for CFLAGS.
Used in harfbuzz.
3) Add option "-xannotate=no" for Sun Studio 12.1 (Sun C++ 5.10)
It is required on latest OpenSolaris.
4) Support for VPX_X86_ASM
(Assignee)

Comment 1

9 years ago
Created attachment 454020 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #454020 - Flags: review?(benjamin)

Updated

9 years ago
Attachment #454020 - Flags: review?(benjamin) → review+
Ginn, I'm not opposed to this c-c change, but in the future could you please request review from a c-c build peer for a c-c portion.

The primary reason is that c-c has some divergence from m-c for build system. (We're behind in some cases for one; and for two, there are many patches that need mozilla/ added to the stuff as we don't copy EVERY file that we use).

I am a reviewer for the c-c side of things, and can promise fast reviews especially if the patch ALREADY has a m-c review+
Blocks: 548218
Flags: in-testsuite-
Target Milestone: --- → mozilla2.0b1
Version: unspecified → Trunk

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.