574662 - Move pushlog back from changegroup to pretxnchangegroup hook?

Status: RESOLVED WONTFIX

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Axel Hecht]

I was wondering if we can move pushlog back to the pretxn hook, like this:

Enable the single-head hook in the global hgrc before the pushlog hook, and make it check a setting in the repo on whether it is actually supposed to guard, same for tree status.

Could be something like

[mozhooks]
single-head=1
tree-status=1

in the local .hg/hgrcs for the repos where we want them.

The fact that we already seen tickets to get manual clean up on our pushlog dbs concerns me a good deal, and this should enable us to work around that.

Comment 1

[(not currently active) Ted Mielczarek]

This is more of a Server Ops bug than Hg: Customization, since nobody but IT can fiddle with the hg setup on hg.mo.

Comment 2

[Axel Hecht]

We would need to patch the hooks first, though.

Comment 3

[Gregory Szorc [:gps]]

pretxnchangegroup is the proper place for the hook. The bug that needs fixed is to have the pushlog roll back if the transaction is aborted.