Few links are missing /language code

VERIFIED FIXED in 4.x (triaged)

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: Pratibha, Unassigned)

Tracking

unspecified
4.x (triaged)
x86
All

Details

(URL)

(Reporter)

Description

8 years ago
Steps:
------
1)Load AMO home page, https://addons.mozilla.org
2)Mouse hover on the following links in home page:
-Visit the Developer Hub
-Collection names listed under Popular Collections section

Result: the links are missing /language-country code

A scenario where this might be an issue to the users:
-Browser language is set to some non-english say "Italian"
-When AMO page is accessed, it loads in Italian language
-Select from Other Languages:English(en-US) to work with english pages
-Page reloads and displayed in English language
-Now click on Visit the Developer Hub,or any collection name loads the page in Italian language as browser language is picked in this case
(Reporter)

Comment 1

8 years ago
Also seen on preview server: https://preview.addons.mozilla.org

Updated

8 years ago
Target Milestone: --- → 5.11.4
Links usually omit the language code on purpose; 9/10 times, the user's accept-language header is what their preference is.  The pulldown in the footer is usually intended to override that (if, for example, it's not correctly detected).
These are all already marked with TODO tags in the code.  Right now they don't have the language because they aren't being reverse()'d in the code.  Once we do collections in Q3 the collections links will be fixed.  As we migrate more pages over, links like this will get fixed.
Target Milestone: 5.11.4 → 4.x (triaged)
Fixed or wontfix based on comment 3.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

7 years ago
Verified at :
https://addons-dev.allizom.org/it/firefox/
https://addons-dev.allizom.org/en-US/firefox/

Links show the same /language code in which the pages are loaded initially
Status: RESOLVED → VERIFIED
(Assignee)

Updated

2 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.