Closed Bug 574717 Opened 10 years ago Closed 10 years ago

Stub out ipc plugin stuff for Android

Categories

(Core :: IPC, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #454076 - Flags: review?(jones.chris.g)
Comment on attachment 454076 [details] [diff] [review]
Patch

>diff --git a/dom/plugins/NPEventAndroid.h b/dom/plugins/NPEventAndroid.h
>new file mode 100644
>--- /dev/null
>+++ b/dom/plugins/NPEventAndroid.h
>@@ -0,0 +1,95 @@
[...]
>+namespace IPC {
>+
>+template <>
>+struct ParamTraits<mozilla::plugins::NPRemoteEvent>     // synonym for XEvent

Nuke that comment.

[...]
>+    static void Log(const paramType& aParam, std::wstring* aLog)
>+    {
>+        // TODO
>+        aLog->append(L"(XEvent)");

"AndroidEvent"?

Looks fine, thanks for putting up with the ping-ponging.
Attachment #454076 - Flags: review?(jones.chris.g) → review+
http://hg.mozilla.org/projects/electrolysis/rev/c62406f6a060
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.