Closed Bug 5748 Opened 25 years ago Closed 25 years ago

In Editor, a link is inserted even though no URL was specified

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: chrispetersen, Assigned: cmanske)

Details

Version: Apprunner
Build: April 29th build. (1999042908)
Expected Results: If no url is specified in the Link to field, the link should
not be inserted.
What I got: The linked text is inserted into the document.
Steps to Reproduce:
1) Launch Apprunner.
2) Select Editor from the Task menu.
3) Place cursor in document and click on  Link from the toolbar.
4) Type in some text for the link source. (Text that is to displayed in the
document)
5) Leave the Link to field empty. Click the OK button.
6) Notice that the linked text is inserted.Since there isn't a url source
specified, the linked text shouldn't be inserted.
Assignee: kostello → akkana
Target Milestone: M6
Assign to Akkana
Assignee: akkana → cmanske
Part of the link dialog rework.
Status: NEW → ASSIGNED
Target Milestone: M6 → M7
Based on the "crawl, walk, run" philosophy, we think it is better to get more
dialogs working rather than getting each one perfect.
Its OK to file bugs on missing behavior, of course, I'm just explaining the
implementation process.
Target Milestone: M7 → M9
It would be best to fix this after the "onchange" handler works for text
fields, so postponing for a better milestone.
Thinking about this, I'm not sure its a bug. In the case of a new link, if
there is no URL, nothing happens (we don't insert the "A" tag), so no harm done.
In the case of an existing link, allowing the user to delete the URL
seems a logic way to remove the link. Otherwise they have to know about the
"Remove Link(s)" item in the Format menu.
Any opinions? (I'll bring up the issue in the editor and UI news groups)
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Checked in 7/22
We now allow an empty link editfield as a means to remove an existing link:
Select some text, click on the link button, enter the link URL (if you leave
this empty, no link will be created), click OK.
Click on the link button again, you should see the link URL you typed before.
If you clear that text and click OK, the link should be removed from the
document.
Status: RESOLVED → VERIFIED
verified in 7/26 build.
You need to log in before you can comment on or make changes to this bug.