Closed Bug 574821 Opened 14 years ago Closed 14 years ago

Drawing in the title bar is broken when the window is maximized

Categories

(Core :: Widget: Win32, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta2+

People

(Reporter: jrmuizel, Assigned: jimm)

References

()

Details

Attachments

(2 files, 3 obsolete files)

The minefield button goes off the screen and the search box overlaps the window controls.
Blocks: 513162
blocking2.0: --- → ?
Component: General → Widget: Win32
Product: Firefox → Core
QA Contact: general → win32
bug 574434 changed how the titlebar is smaller on Aero and the toolbars are sitting on top of the controls and menu.  The menu button is thinner now than it was before that bug.  The toolbars look bumped up.

As far as the menu being off the screen, maybe its rendered at the window outside border edge, while the window controls are looking at the inside border edge.. 
The toolbars look pushed up, but why can't they just stay where they were?
The menu bar height is also different between tabs on top and tabs on bottom.  This can be seen in Win7 by switching the default theme to Windows Classic and using the app menu compared to the menu bar.
I've already reported that in bug 574681.
As I said in bug 574954, the distance between the top of the Navigation bar and the top of the window is smaller when you maximize the window than it is when the window is not maximized.  Same goes for the distance between the window controls in the upper right corner and the top of the navigation bar.
Attached patch patch v.1 (obsolete) — Splinter Review
Assignee: nobody → jmathies
Attached patch patch v.2 (obsolete) — Splinter Review
Attachment #454278 - Attachment is obsolete: true
Attachment #454285 - Flags: review?(tellrob)
Attachment #454285 - Flags: review?(tellrob) → review+
Version: unspecified → Trunk
Blocks: 574802
Blocks: 572312
Can we land this in time for today's nightly?
(In reply to comment #10)
> Can we land this in time for today's nightly?

Nope not in todays nightly's, they are already being built...
Blocks: 575057
When it will land?
(In reply to comment #12)
> When it will land?

There's a problem still with caption buttons and hit testing via the dwm when the fx window is maximized.
Will this patch cover bug 574681?
Attached patch patch v.3 (obsolete) — Splinter Review
Attachment #454361 - Attachment is obsolete: true
Attachment #454363 - Flags: review?(tellrob)
An explanation for the browser folks: with maximized windows, the origin of the window (on windows) is placed at -8, -8 on the screen. The original patch posted here that rob r+'d fixed the problem by pushing the client area down within the window. Unfortunately this broke caption button hit testing, because the dwm's DwmDefWndProc hit testing code expects the client to be properly placed at the window origin.

This css patch adds an 8px margin to main-window to handle offsetting content instead.

I've also added an earlier sizemode event in widget sent before the window updates, so that rendering the Fx button in the proper place happens when the frame transition takes place.
Attachment #454364 - Flags: review?
Attachment #454364 - Flags: review? → review?(dao)
Attachment #454364 - Flags: review?(dao) → review+
Comment on attachment 454363 [details] [diff] [review]
widget: cleanup and earlier sizemode event

Been playing around with this locally for some time - seems to work.
Attachment #454363 - Flags: review?(tellrob) → review+
Attachment #454285 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 575228
Blocks: 575493
No longer blocks: 575228
Depends on: 575228
You need to log in before you can comment on or make changes to this bug.