574869 - Mac build without libxul fails for me because the IOKit framework is missing

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

Here's what I get from make in layout/build:

Undefined symbols:
  "_IOMasterPort", referenced from:
      nsAccelerometerSystem::Startup()      in nsAccelerometerSystem.o
  "_IOServiceGetMatchingServices", referenced from:
      nsAccelerometerSystem::Startup()      in nsAccelerometerSystem.o
  "_IOServiceMatching", referenced from:
      nsAccelerometerSystem::Startup()      in nsAccelerometerSystem.o
  "_IOIteratorNext", referenced from:
      nsAccelerometerSystem::Startup()      in nsAccelerometerSystem.o
  "_IOConnectCallStructMethod", referenced from:
      nsAccelerometerSystem::UpdateHandler(nsITimer*, void*)  in nsAccelerometerSystem.o
  "_IOObjectRelease", referenced from:
      nsAccelerometerSystem::Startup()      in nsAccelerometerSystem.o
      nsAccelerometerSystem::Startup()      in nsAccelerometerSystem.o
  "_IOServiceClose", referenced from:
      nsAccelerometerSystem::Shutdown()      in nsAccelerometerSystem.o
  "_IOServiceOpen", referenced from:
      nsAccelerometerSystem::Startup()      in nsAccelerometerSystem.o
ld: symbol(s) not found

in widget/src/cocoa/Makefile.in, we add the IOKit framework, and I guess we should do the same in layout/build/Makefile.in as well.  I don't know how this used to work, and what changed to make it break, but I have a simple patch which fixes this.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(no longer active)]

This is a regression from bug 562181, FWIW.

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/c3351a1a3699

Thanks a lot for the quick review!

Comment 4

[Justin Wood (:Callek)]

I just midaired with ehsan as well, but for posterity I'm posting my comment anyway:

Full range for SeaMonkey; http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b51803f3fdef%20&tochange=31c52b96e75e

Inspection blames: http://hg.mozilla.org/mozilla-central/rev/1d4e2804796a
(Bug 562181  - Add support for MozOrientation on Qt. r=dougt )

Comment 5

[Justin Wood (:Callek)]

VERIFIED; based on SeaMonkey builders succeeding.

Comment 6

[Mike Kristoffersen (:MikeK)]

(In reply to comment #2)
> This is a regression from bug 562181, FWIW.

Which I seem to have made - sorry about that....  Happy that you could fix it so quickly :)