574962 - Invisible GLODA search box on toolbar and during customization when indexing is disabled

Status: NEW

(Thunderbird :: Search, defect)

Description

[Charles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100611 Firefox/3.6.4
Build Identifier: 3.1 final

On a system with TB 3.0.x already installed and GLODA is disabled, after updating to 3.1, what was the GLODA searchbox is still on the toolbar, but it is invisible. When dragged off of the toolbar, you can see *only* the label 'Global Search', but no searchbox.

Reproducible: Always

Steps to Reproduce:
1. Disable GLODA on 3.0.x system
2. Place the combo GLODA/Quickfilter searchbox on the MENU toolbar
3. Update to 3.1.
4. Observe that the GLODA searchbox is still on the MENU toolbar, but is invisible.
5. View > Toolbars > Configure, and move the invisible searchbox off of the MENU toolbar, and now you see *only* the text/label 'Global Search'.
Actual Results:  
Invisible 'Global Search' toolbar button on MENU toolbar after update, and only text/label shows when it is moved off the toolbar.

Expected Results:  
Not sure if it should automatically be removed from the toolbar, but you should at least be able to see the searchbox.

I haven't tested if this problem exists on a system that has the searchbox in the normal position (Mail Toolbar)...

Comment 1

[rsx11m]

I think that's on purpose to indicate that the global search is not available. The quick-filter bar is now separate, thus it wouldn't have any function.

Comment 2

[rsx11m]

> Not sure if it should automatically be removed from the toolbar, but you should
> at least be able to see the searchbox.

You could decide later to switch on Gloda, then it's reappearing. Thus, removing it on upgrade may not be a good thing to do either.

Comment 3

[Charles]

I understand, but having an INVISIBLE THING there on the toolbar is really just dumb. Have a greyed out/disabled searchbox. People understrand greyed out. They don't understand INVISIBLE.

Comment 4

[Charles]

Please don't tell me this bug is another 'feature' that won't be fixed.

Comment 5

[rsx11m]

I'm not telling you anything, and I'm not the one to decide on that anyway.
I was merely responding to provide a possible explanation and reasoning...

Comment 6

[Rimas Kudelis [use needinfo to ping]]

I agree it should be greyed out. Making it invisible certainly doesn't make sense.

Comment 7

[Rimas Kudelis [use needinfo to ping]]

By the way it doesn't seem to happen if I disable synchronization using the migration assistant.

Comment 8

[rsx11m]

I have both synchronization and indexing disabled (profile was migrated from
2.0 over 3.0 to 3.1, so may be a slightly different case) and the Gloda bar
is invisible. If I select "Customize", I can see a gray field in the toolbar where it used to be and could move it into the customization palette.

Just showing it disabled and therefor giving the user a hint that something
is there (also making it easier then to grab it in the customization dialog) seems like a good idea.

Comment 9

[Charles]

(In reply to comment #7)
> By the way it doesn't seem to happen if I disable synchronization using the
> migration assistant.

But the migration assistant only rears its head when upgrading from TB2.0.x...

This bug is about upgrading from 3.0.x to 3.1...

Comment 10

[Charles]

(In reply to comment #8)
> I have both synchronization and indexing disabled (profile was migrated from
> 2.0 over 3.0 to 3.1, so may be a slightly different case)

Most of our profiles were migrated from 2.0.x - I know mine was...

> and the Gloda bar is invisible. If I select "Customize", I can see a
> gray field in the toolbar where it used to be

Are you sure you actually see a 'grey field'? Mine is completely invisible - it just looks like empty space - in fact, when the toolbar is in edit mode, it looks exactly like the blank space you see on a toolbar in normal mode where you have placed a 'Flexible Space' holder...

> and could move it into the customization palette.

I can move it, but I still don't see a searchbox, just the Label for it: 'Global Search'.

Comment 11

[rsx11m]

(In reply to comment #10)
> Are you sure you actually see a 'grey field'? Mine is completely invisible - it
> just looks like empty space - in fact, when the toolbar is in edit mode, it
> looks exactly like the blank space you see on a toolbar in normal mode where
> you have placed a 'Flexible Space' holder...

Yes, that's what I meant - I see the separator (white) and then the Gloda bar where it was in dialog-background color (same on Windows and Linux).

I'm confirming this as there seems to be room for improving the experience here, within the customization dialog as the minimum. It also appears to be independent of whether or not the profile was migrated, it looks equally gray with a new profile when switching off indexing. I've adjusted the summary.

Comment 12

[Charles]

Cool, thanks...

Comment 13

[Wayne Mery (:wsmwk)]

Does this reproduce when using version 115?