crash in RDFContentSinkImpl::GetNameSpaceURI -- [*debug-only/logging-only*]

VERIFIED FIXED in mozilla0.9

Status

()

Core
RDF
P3
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: John Morrison, Assigned: Chris Waterson)

Tracking

({crash})

Trunk
mozilla0.9
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
I turned on logging and hit a crash on start in RDF (set 
NSPR_LOG_MODULES=all:2).

The crash happens in RDFContentSinkImpl::GetNameSpaceURI, in stuff that
is running debug only.

#ifdef PR_LOGGING
    if (PR_LOG_TEST(gLog, PR_LOG_ALWAYS)) {
        nsAutoString prefixStr;
        aPrefix->ToString(prefixStr);                  <-- boom!

        char* prefixCStr = prefixStr.ToNewCString();

        PR_LOG(gLog, PR_LOG_ALWAYS,
               ("rdfxml: undeclared namespace prefix '%s'",
                prefixCStr));

        nsCRT::free(prefixCStr);
    }
#endif

aPrefix is null because (as far as I could tell) the tagName was
<open>, with no qualifying namespace. Perhaps this is obsolete logging
code, or perhaps you just need to check the null pointer.

I'll attach the localstore.rdf in case you really want to track this 
down (probably not, since this is just in error reporting).
(Reporter)

Comment 1

17 years ago
Created attachment 17704 [details]
localstore.rdf that could trigger this crash (seems normal though)
(Assignee)

Comment 2

17 years ago
That's a bona fide bug; I think I wrote the logging code before we started 
"bending the rules" in localstore.rdf.
Status: NEW → ASSIGNED
Keywords: crash
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 3

17 years ago
Heh, well whadyaknow. dougt fixed this with his necko landing! *kiss*
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 4

17 years ago
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.