57497 - crash in RDFContentSinkImpl::GetNameSpaceURI -- [*debug-only/logging-only*]

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect, P3)

Description

[John Morrison]

I turned on logging and hit a crash on start in RDF (set 
NSPR_LOG_MODULES=all:2).

The crash happens in RDFContentSinkImpl::GetNameSpaceURI, in stuff that
is running debug only.

#ifdef PR_LOGGING
    if (PR_LOG_TEST(gLog, PR_LOG_ALWAYS)) {
        nsAutoString prefixStr;
        aPrefix->ToString(prefixStr);                  <-- boom!

        char* prefixCStr = prefixStr.ToNewCString();

        PR_LOG(gLog, PR_LOG_ALWAYS,
               ("rdfxml: undeclared namespace prefix '%s'",
                prefixCStr));

        nsCRT::free(prefixCStr);
    }
#endif

aPrefix is null because (as far as I could tell) the tagName was
<open>, with no qualifying namespace. Perhaps this is obsolete logging
code, or perhaps you just need to check the null pointer.

I'll attach the localstore.rdf in case you really want to track this 
down (probably not, since this is just in error reporting).

Comment 1

[John Morrison]

Attachment: localstore.rdf that could trigger this crash (seems normal though)

Comment 2

[Chris Waterson]

That's a bona fide bug; I think I wrote the logging code before we started 
"bending the rules" in localstore.rdf.

Comment 3

[Chris Waterson]

Heh, well whadyaknow. dougt fixed this with his necko landing! *kiss*

Comment 4

[Tom Everingham]

verified