Closed Bug 575056 Opened 14 years ago Closed 14 years ago

Background tabs should be more opaque

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b7
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: imradyurrad, Assigned: dao)

References

Details

Attachments

(2 files)

mockups
348.48 KB, image/png
Details
patch
1.13 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100626 Minefield/3.7a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100626 Minefield/3.7a6pre

The tab gradients in the mockups are easier to see.

Reproducible: Always
Component: General → Tabbed Browser
Depends on: 560507
Whiteboard: tabs
Version: unspecified → Trunk
Attached image mockups — 

    
  
OS: Windows 7 → All

    
  
Priority: -- → P3
Priority: P3 → --
Whiteboard: tabs
Component: Tabbed Browser → Theme
QA Contact: general → theme
Blocks: 560507
No longer depends on: 560507

    
  
OS: All → Windows 7

    
  
Summary: Adjust inactive tabs gradient to match mockups → [meta] Adjust inactive tabs gradient to match mockups
Whiteboard: meta

    
  
Keywords: meta
Whiteboard: meta

    
    

    
  
The tabs aren't even supposed to have any transparency.

    
  
Summary: [meta] Adjust inactive tabs gradient to match mockups → Adjust inactive tabs gradient to match mockups

    
  
Severity: minor → normal

    
  
Keywords: meta

    
  
Severity: normal → enhancement

    
  
Depends on: 581770

    
    

    
  
Ah, I'm glad to find this bug.

As it is now, it is quite tricky to see which is the active tab. I was about to file a bug to make the active tab title bold, but this bug should sort it out.

    
    

    
  
shorlander: can you help us with some direction here, looks pretty bad on dark glass backgrounds.
blocking2.0: --- → betaN+

    
    

    
  
See attachment 469931 [details] for an example of "pretty bad"
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  
(In reply to comment #5)
> shorlander: can you help us with some direction here, looks pretty bad on dark
> glass backgrounds.

I think this is actually a dupe of bug 570280. I just need to update my patch there. But as seen in the mockup attached here they should be much more opaque and specific CSS values are in attachment 453121 [details] [diff] [review].

    
  
Summary: Adjust inactive tabs gradient to match mockups → Background tabs should be more opaque

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
Assignee: nobody → dao
Status: NEW → ASSIGNED

        Attachment #471794 -
        Flags: review?(gavin.sharp)

    
  
Blocks: 570280

    
  
Severity: enhancement → normal

    
    

    
  
Comment on attachment 471794 [details] [diff] [review]
patch

rs=me

        Attachment #471794 -
        Flags: review?(gavin.sharp) → review+

    
  
Whiteboard: [checkin-needed]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/bd474ff6f86c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → Firefox 4.0b6

    
    

    
  
Verified fixed using an hourly build.  I can finally read background tabs titles on top of my dark desktop backgrounds and especially command prompt.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100904 Firefox/4.0b6pre (cset bd474ff6f86c)
Status: RESOLVED → VERIFIED

    
  
No longer depends on: 593680

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: