575094 - e10s: test_bug528292.js relies on prefservice and fails in child

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Josh Matthews [:jdm]]

I noticed this when looking at this log: http://tinderbox.mozilla.org/showlog.cgi?log=Electrolysis/1277638496.1277639938.9418.gz
Tests such as test_bug528292 are failing like so:

child: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPrefBranch.setIntPref]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: /builds/slave/electrolysis-linux-opt-unittest-xpcshell/build/xpcshell/tests/test_necko/unit/test_bug528292.js :: run_test :: line 37"  data: no]child: 

Since the test relies on third party cookies being disabled, the test is useless is its current form from the content process.  Any test that relies on the prefservice should be rewritten such that the pref is set in chrome before the rest of the test executes.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Patch

This makes the test a bit more complicated, but runs the prefservice code in chrome, and adds cleanup as well.

Comment 2

[Josh Matthews [:jdm]]

Note that the test still fails because redirects are busted, but it fails for a better reason than before now.

Comment 3

[Doug Turner (:dougt)]

can we remove this test until redirect pass?  or have them issue a todo as well?

Comment 4

[Jason Duell]

I've disabled the test for now (bug 575845) by renaming it.  

  http://hg.mozilla.org/projects/electrolysis/rev/17d94262d309

Just "hg rename" it back when it's working.

Comment 5

[Josh Matthews [:jdm]]

I think my patch is more complicated than necessary. Let's rename the file and add the usual process type check (http://mxr.mozilla.org/mozilla-central/source/modules/libjar/test/unit/head_ipc.js#9) around the pref setting code. The we can just duplicate the pref code around the call to run_test_in_child and everything should Just Work.

Comment 6

[Josh Matthews [:jdm]]

Note: the way to run this test after renaming is ./mach xpcshell-test netwerk/test/unit_ipc/test_bug528292_wrap.js (and make sure to update the xpcshell.ini that's in the same directory as well).

Comment 7

[Connor [:cojo]]

Attachment: 575094-reenable-test_bug528292_wrap.diff

> Let's rename the file and add the usual process type check
> (http://mxr.mozilla.org/mozilla-central/source/modules/libjar/test/unit/head_ipc.js#9) 
> around the pref setting code. 
> The we can just duplicate the pref code around the 
> call to run_test_in_child and everything should Just Work.

I think this patch should satisfy the above requirements. I based the changes off other similar tests (ie: the inChildProcess() function comes from [1], and the changes to test_bug528292_wrap.js are based on [2]).

Both test_bug528292_wrap.js and test_bug528292.js ran without errors (caveat emptor: everything under netwerk/tests/unit_ipc/ was disabled for Mac OSX [3], so I had to fiddle to get test_bug528292_wrap.js to run at all).

[1] http://dxr.mozilla.org/mozilla-central/source/netwerk/cookie/test/unit/test_parser_0001.js#7
[2] http://dxr.mozilla.org/mozilla-central/source/netwerk/test/unit_ipc/test_cookie_header_wrap.js
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=575918

Comment 8

[Josh Matthews [:jdm]]

Comment on attachment 8514020 [details] [diff] [review]
575094-reenable-test_bug528292_wrap.diff

Review of attachment 8514020 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Apologies for the delay; I was on vacation. Please also format the commit message as "Bug #### - message. r=jdm"

Comment 9

[Connor [:cojo]]

Attachment: 575094-reenable-test_bug528292_wrap-2.diff

> Thanks! Apologies for the delay; I was on vacation. Please also format the commit message as "Bug #### - message. r=jdm"
No worries. I modified the commit message and carried the r+ through.

Comment 10

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e021487d1297

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e021487d1297