575095 - Don't use gdk_pixbuf_unref

Status: RESOLVED DUPLICATE of bug 474116

(Core :: Widget: Gtk, defect)

Description

[Guido Günther]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100623 Iceweasel/3.5.10 (like Firefox/3.5.10)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100623 Iceweasel/3.5.10 (like Firefox/3.5.10)

widget/src/gtk2/nsWindow.cpp uses gdk_pixbuf_unref which is deprecated in gdk_pixbuf since 2.0 (since about 2001):

http://library.gnome.org/devel/gdk-pixbuf/stable/gdk-pixbuf-refcounting.html

Attached patch replaces this by calls to g_object_unref.

Reproducible: Always

Actual Results:  
Shouldn't use gdk_pixbuf_unref

Expected Results:  
Should use g_object_unref

gdk_pixbuf_unref will go away for GTK+-3.0

Comment 1

[Guido Günther]

Attachment: Use g_object_unref() instead of gdk_pixbuf_unref()

Comment 2

[Kevin Brosnan]

Ask for review from Karl Tomlinson, http://www.mozilla.org/about/owners.html#widget-gtk

https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch#Getting_Reviews

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 454367 [details] [diff] [review]
Use g_object_unref() instead of gdk_pixbuf_unref()

Thank you.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

this patch does not apply cleanly, please attach an updated patch and re-ask for c-n.

Comment 5

[Guido Günther]

Already fixed in mozilla-central trunk, so closing.

Comment 6

[Guido Günther]

Already fixed in mozilla-central trunk, so closing.