Closed
Bug 575096
Opened 16 years ago
Closed 16 years ago
Shouldn't use gdk_pixbuf_unref
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 474116
People
(Reporter: agx, Assigned: agx)
Details
Attachments
(1 file)
|
1.63 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100623 Iceweasel/3.5.10 (like Firefox/3.5.10)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100623 Iceweasel/3.5.10 (like Firefox/3.5.10)
libpr0n/decoders/icon/gtk/nsIconChannel.cpp uses gdk_pixbuf_unref which is deprecated in gdk_pixbuf since 2.0 (since about 2001):
http://library.gnome.org/devel/gdk-pixbuf/stable/gdk-pixbuf-refcounting.html
Attached patch replaces this by calls to g_object_unref.
Reproducible: Always
Actual Results:
Shouldn't use gdk_pixbuf_unref
Expected Results:
Should use g_object_unref.
|
Assignee | |
Comment 1•16 years ago
|
||
|
||
Comment 2•16 years ago
|
||
Same as bug 575095 comment 2
Ask for review from Karl Tomlinson, http://www.mozilla.org/about/owners.html#widget-gtk
|
|
Assignee | |
Updated•16 years ago
|
Attachment #454368 -
Flags: review?(karlt)
|
||
Updated•16 years ago
|
Attachment #454368 -
Flags: review?(karlt) → review+
|
|
||
Updated•16 years ago
|
|
||
Comment 3•16 years ago
|
||
this patch does not apply cleanly, please attach an updated patch and re-ask for c-n.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•16 years ago
|
||
Fixed in mozilla-central trunk so closing.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Resolution: FIXED → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•