Closed Bug 575156 Opened 9 years ago Closed 9 years ago

Apply the needed NS_NEWXPCOM/NS_DELETEXPCOM changes from Bug 562387 to Comm-Central

Categories

(MailNews Core :: Backend, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(2 files, 2 obsolete files)

Removing NS_NEWXPCOM/NS_DELETEXPCOM from the Comm-Central tree and replace
it with new/delete.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Component: MailNews: Backend → Backend
Product: SeaMonkey → MailNews Core
QA Contact: mailnews-backend → backend
Depends on: 562387
Attachment #454430 - Flags: feedback?(bugspam.Callek)
Attachment #454430 - Flags: review?(neil)
Comment on attachment 454430 [details] [diff] [review]
Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central

This patch looks good, but we also need the directory/xpcom changes done too. (+ Please kill the related comment in calendar/ for NS_NEWXPCOM)
Attachment #454430 - Flags: feedback?(bugspam.Callek) → feedback+
(Fixed an incorrect reference.)
Attachment #454449 - Flags: review?(neil)
Attachment #454449 - Flags: feedback+
Attachment #454449 - Attachment is obsolete: true
Attachment #454449 - Flags: review?(neil)
Attachment #454449 - Attachment is obsolete: false
Attachment #454449 - Flags: review?(neil)
Attachment #454430 - Attachment is obsolete: true
Attachment #454430 - Flags: review?(neil)
Comment on attachment 454449 [details] [diff] [review]
Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central

>-  nsMsgDBView* newMsgDBView;
>-
>-  NS_NEWXPCOM(newMsgDBView, nsMsgDBView);
>+  nsMsgDBView* newMsgDBView = new nsMsgDBView();
>+
[Weird hg diff bug? Compare below]
>-  nsMsgSearchDBView* newMsgDBView;
>+  nsMsgSearchDBView* newMsgDBView = new nsMsgSearchDBView();
> 
>-  NS_NEWXPCOM(newMsgDBView, nsMsgSearchDBView);

>   {
>-    NS_NEWXPCOM(m_compFields, nsMsgCompFields);
>+    nsMsgCompFields* m_compFields = new nsMsgCompFields();
This one looks wrong, I think?
I presume that you are going to do directory/ and calendar/ later?
(In reply to comment #5)
> I presume that you are going to do directory/ and calendar/ later?

Yes.  I made a new bug for directory/.  Will do calendar/ next.  
Just need to fix up this patch first.
(In reply to comment #4)
> (From update of attachment 454449 [details] [diff] [review])
> >-  nsMsgDBView* newMsgDBView;
> >-
> >-  NS_NEWXPCOM(newMsgDBView, nsMsgDBView);
> >+  nsMsgDBView* newMsgDBView = new nsMsgDBView();
> >+
> [Weird hg diff bug? Compare below]
> >-  nsMsgSearchDBView* newMsgDBView;
> >+  nsMsgSearchDBView* newMsgDBView = new nsMsgSearchDBView();
> > 
> >-  NS_NEWXPCOM(newMsgDBView, nsMsgSearchDBView);

Not really weird.  For the first diff,  I replaced NS_NEWXPCOM(..)
with nsMsgDBView* newMsgDBView = new nsMsgDBView();.

For the 2nd diff,  I replaced nsMsgSearchDBView* newMsgDBView; with
nsMsgSearchDBView* newMsgDBView = new nsMsgSearchDBView(); and then
deleted the NS_NEWXPCOM(...) line.  

Although when I did it, I didn't think it would make any difference;
but apparently it does.  Might this be a problem in the future?

> 
> >   {
> >-    NS_NEWXPCOM(m_compFields, nsMsgCompFields);
> >+    nsMsgCompFields* m_compFields = new nsMsgCompFields();
> This one looks wrong, I think?
Attachment #454449 - Attachment is obsolete: true
Attachment #454756 - Flags: review?(neil)
Attachment #454756 - Flags: feedback+
Attachment #454449 - Flags: review?(neil)
calendar/ only contains one NS_NEWXPCOM instance and it is a
comment one.  I'm attaching it to this bug instead of creating a 
new one.
Attachment #454760 - Flags: review?(bugspam.Callek)
Attachment #454760 - Flags: review?(bugspam.Callek) → review+
Attachment #454756 - Attachment is patch: true
Attachment #454756 - Attachment mime type: application/octet-stream → text/plain
Attachment #454756 - Flags: review?(neil) → review+
Comment on attachment 454756 [details] [diff] [review]
 Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central   (v2)

Strictly speaking you still need sr for touching mailnews, so sr=Standard8.
Attachment #454756 - Flags: superreview+
Both patches checked in to fix further c-c bustage now the core patch landed:

http://hg.mozilla.org/comm-central/rev/5550f06d4b83
http://hg.mozilla.org/comm-central/rev/4178007c058c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.