575156 - Apply the needed NS_NEWXPCOM/NS_DELETEXPCOM changes from Bug 562387 to Comm-Central

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Edmund Wong (:ewong)]

Removing NS_NEWXPCOM/NS_DELETEXPCOM from the Comm-Central tree and replace
it with new/delete.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 454430 [details] [diff] [review]
Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central

This patch looks good, but we also need the directory/xpcom changes done too. (+ Please kill the related comment in calendar/ for NS_NEWXPCOM)

Comment 3

[Edmund Wong (:ewong)]

Attachment: Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central

(Fixed an incorrect reference.)

Comment 4

[[e-mail]]

Comment on attachment 454449 [details] [diff] [review]
Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central

>-  nsMsgDBView* newMsgDBView;
>-
>-  NS_NEWXPCOM(newMsgDBView, nsMsgDBView);
>+  nsMsgDBView* newMsgDBView = new nsMsgDBView();
>+
[Weird hg diff bug? Compare below]
>-  nsMsgSearchDBView* newMsgDBView;
>+  nsMsgSearchDBView* newMsgDBView = new nsMsgSearchDBView();
> 
>-  NS_NEWXPCOM(newMsgDBView, nsMsgSearchDBView);

>   {
>-    NS_NEWXPCOM(m_compFields, nsMsgCompFields);
>+    nsMsgCompFields* m_compFields = new nsMsgCompFields();
This one looks wrong, I think?

Comment 5

[Philip Chee]

I presume that you are going to do directory/ and calendar/ later?

Comment 6

[Edmund Wong (:ewong)]

(In reply to comment #5)
> I presume that you are going to do directory/ and calendar/ later?

Yes.  I made a new bug for directory/.  Will do calendar/ next.  
Just need to fix up this patch first.

Comment 7

[Edmund Wong (:ewong)]

(In reply to comment #4)
> (From update of attachment 454449 [details] [diff] [review])
> >-  nsMsgDBView* newMsgDBView;
> >-
> >-  NS_NEWXPCOM(newMsgDBView, nsMsgDBView);
> >+  nsMsgDBView* newMsgDBView = new nsMsgDBView();
> >+
> [Weird hg diff bug? Compare below]
> >-  nsMsgSearchDBView* newMsgDBView;
> >+  nsMsgSearchDBView* newMsgDBView = new nsMsgSearchDBView();
> > 
> >-  NS_NEWXPCOM(newMsgDBView, nsMsgSearchDBView);

Not really weird.  For the first diff,  I replaced NS_NEWXPCOM(..)
with nsMsgDBView* newMsgDBView = new nsMsgDBView();.

For the 2nd diff,  I replaced nsMsgSearchDBView* newMsgDBView; with
nsMsgSearchDBView* newMsgDBView = new nsMsgSearchDBView(); and then
deleted the NS_NEWXPCOM(...) line.  

Although when I did it, I didn't think it would make any difference;
but apparently it does.  Might this be a problem in the future?

> 
> >   {
> >-    NS_NEWXPCOM(m_compFields, nsMsgCompFields);
> >+    nsMsgCompFields* m_compFields = new nsMsgCompFields();
> This one looks wrong, I think?

Comment 8

[Edmund Wong (:ewong)]

Attachment: Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central (v2)

Comment 9

[Edmund Wong (:ewong)]

Attachment: Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central (calendar/)

calendar/ only contains one NS_NEWXPCOM instance and it is a
comment one.  I'm attaching it to this bug instead of creating a 
new one.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 454756 [details] [diff] [review]
 Removed references of NS_NEWXPCOM/NS_DELETEXPCOM in comm-central   (v2)

Strictly speaking you still need sr for touching mailnews, so sr=Standard8.

Comment 11

[Mark Banner (:standard8)]

Both patches checked in to fix further c-c bustage now the core patch landed:

http://hg.mozilla.org/comm-central/rev/5550f06d4b83
http://hg.mozilla.org/comm-central/rev/4178007c058c