Closed Bug 575172 Opened 9 years ago Closed 9 years ago

Both the tablist and tabpreview icon is visible at the same time

Categories

(Core :: CSS Parsing and Computation, defect, P1)

x86_64
Linux
defect

Tracking

()

VERIFIED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: cork, Assigned: bzbarsky)

References

Details

(Keywords: regression)

Attachments

(1 file)

When browser.allTabs.previews is set to true. Untill the button is hovered both the preview icon and the tab list arrow is visible at the time.

Reproducible: Always

Steps to Reproduce:
1. Create a new profile
2. Go to about:config and set browser.allTabs.previews to true

Actual Results:  
The toolbar becomes slightly higher and both the for box icon and the arrow is shown.

Expected Results:  
The preview button should only have the four box icon.


This happens every time browser.allTabs.previews is set to true or firefox is restarted.

Regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=88fa0b783306&tochange=d4156799e66a
Component: Theme → Style System (CSS)
Keywords: regression
Product: Firefox → Core
QA Contact: theme → style-system
This is likely relevant:

###!!! ASSERTION: Why did this not get handled while processing mRestyleRoots?: '!element->HasFlag(collector->tracker->RootBit()) || (element->GetFlattenedTreeParent() && (!element->GetFlattenedTreeParent()->GetPrimaryFrame()|| element->GetFlattenedTreeParent()->GetPrimaryFrame()->IsLeaf())) || (aData.mChangeHint & nsChangeHint_ReconstructFrame)', file ../../../mozilla/layout/base/RestyleTracker.cpp, line 120
blocking2.0: --- → ?
blocking2.0: ? → betaN+
Assignee: nobody → bzbarsky
Priority: -- → P1
This is totally my fault.  Yay assertions (and even more yay code actually exercising this script type id stuff).
Blocks: 479655
Whiteboard: [need review]
Cork, I should have mentioned this before but I really appreciate the clear and useful bug report!
Attachment #470846 - Flags: review?(jst) → review+
Whiteboard: [need review] → [need landing]
http://hg.mozilla.org/mozilla-central/rev/05a7e8bafa8a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Whiteboard: [need landing]
Flags: in-testsuite?
Verified in Mozilla/5.0 (X11; Linux x86_64; rv:2.0b6pre) Gecko/20100901 Firefox/4.0b6pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.