Closed Bug 575205 Opened 12 years ago Closed 12 years ago

JM: Make JaegerMonkey work on Solaris x86/x64 with Sun Studio 12.

Categories

(Core :: JavaScript Engine, defect)

x86
Solaris
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: leon.sha, Assigned: leon.sha)

Details

Attachments

(1 file, 1 obsolete file)

18.62 KB, patch
dvander
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — Splinter Review
The patch include following changes:
1. Add TrampolineSUNWX64.s/TrampolineSUNWX86.s
   Asm statement is not allowed outside a function for Sunstudio.
2. X86Assembler.h: We have to use exactly "signed int" to have signed bitfield
3. JS_BITSCAN_REVERSE is not defined if there is no builtin bitscan. Use existing JS_FLOOR_LOG2 macro to get register id.
4. Build error for jscntxt.cpp. This is from patch for bug 568782.
5. Sunstudio do not have fast call. Add support for JS_NO_FASTCALL.
Attachment #454462 - Flags: review?(dvander)
Assignee: general → leon.sha
Status: NEW → ASSIGNED
Attachment #454462 - Attachment is patch: true
Attachment #454462 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 454462 [details] [diff] [review]
patch

Leon, sorry for it not being visible - this branch is effectively dead. You want to take a look at:

http://hg.mozilla.org/projects/jaegermonkey

Most of your changes should still work.
Attachment #454462 - Flags: review?(dvander) → review+
Attached patch patchSplinter Review
Refreshed patch base on jaegermonkey tree. I can not test X64 code since the X64 build is not working currently. The X64 code works OK on http://hg.mozilla.org/users/danderson_mozilla.com/jaegermonkey/.
Attachment #454462 - Attachment is obsolete: true
Attachment #455061 - Flags: review?(dvander)
Attachment #455061 - Flags: review?(dvander) → review+
Thanks, Leon. Yeah, x64 port is probably an August thing.
http://hg.mozilla.org/projects/jaegermonkey/rev/2b690bf41201
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Also commit the part of the patch to fatval.
http://hg.mozilla.org/users/lwagner_mozilla.com/fatval/rev/6346c835a510
You need to log in before you can comment on or make changes to this bug.