Closed Bug 575272 Opened 15 years ago Closed 15 years ago

[ACR Extension] Resetting preferences fails if type is not boolean

Categories

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P1)

Product:
addons.mozilla.org Graveyard
Component:
Compatibility Tools
Version:
ACR-0.*
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
ACR-0.7

People

(Reporter: whimboo, Assigned: mackers)

References

Details

With bug 529100 we now reset all the preferences during each start-up. There is a bug (probably by a missing try/catch clause) which prevents resetting remaining preferences if one of those hasn't the boolean type. Steps: 1. Install the latest ACR extension 2. Open about:config and reset extensions.checkCompatibility 3. Set extensions.checkCompatibility to true (Note it is a string now) 4. Flip the remaining preferences to true 5. Restart Firefox After step 4 none of the remaining preferences has been reset to false. Also extensions.checkCompatibility hasn't been set to a boolean preference again.
-> for a 0.5.1 release.
Assignee: nobody → dave
Target Milestone: --- → ACR-0.*
Version: 3.2 → ACR-0.*
Fixed. - if any checkCompatibility pref is not a boolean, it will be removed first and re-added as a boolean. - if any preference change fails for any reason, the other pref. changes will proceed anyway. r75635, r75641
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Priority: -- → P1
Target Milestone: ACR-0.* → ACR-0.7
Looks good. Marking as verified fixed.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.