575306 - 'cfx testex' should ignore bogus files and empty directories

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

cfx should ignore bogus files and empty directories -- or maybe just cfx test/testall?  They cause errors that are probably cryptic to people just getting started with the SDK.

Via bug 575147, which had a test failure because OS X stuck a .DS_Store in one of the reporter's directories.

Comment 1

[Atul Varma [:atul]]

I can bag this one.

Comment 2

[Atul Varma [:atul]]

Attachment: patch

Comment 3

[Atul Varma [:atul]]

Note that the particular error from bug 575147 is in relation to 'cfx testex', which is run during 'cfx testall'. I've reflected the name of this bug to reflect that.

Comment 4

[Brian Warner [:warner :bwarner]]

Comment on attachment 457419 [details] [diff] [review]
patch

looks good to me. You might want to add an "examples.sort()" in there to make the tests get run in a consistent order.

Comment 5

[Atul Varma [:atul]]

Pushed:

  http://hg.mozilla.org/labs/jetpack-sdk/rev/f918333aaf4b
  http://hg.mozilla.org/labs/jetpack-sdk/rev/aea8c9819d23

Comment 6

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".