Closed Bug 575433 Opened 10 years ago Closed 9 years ago

Remove nsTelProtocol handler

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: blassey)

Details

Attachments

(1 file)

We added the nsTelProtocol handler for supporting tel: on the N810, which doesn't support tel: by default.

The code basically keeps trying callto: and voipto: until one of them works.

The N900 seems to support tel: directly. We aren't actively supporting the N810 for Fennec 2.0, so we can remove this old code. See /usr/share/applications/uri-action-defaults.list:

# This file is maintained by libhildonmime
[Default Actions]
http=hildon-browser.desktop
https=hildon-browser.desktop
ftp=hildon-browser.desktop
mailto=hildon-modest.desktop
chatto=hildon-rtcom-messaging-ui.desktop
xmpp=hildon-rtcom-messaging-ui.desktop
sms=hildon-rtcom-messaging-ui.desktop
voipto=hildon-rtcom-call-ui.desktop
sip=hildon-rtcom-call-ui.desktop
callto=hildon-rtcom-call-ui.desktop
tel=hildon-rtcom-call-ui.desktop
mms=hildon-mediaplayer.desktop
mmsh=hildon-mediaplayer.desktop
rtsp=hildon-mediaplayer.desktop
Attached patch patchSplinter Review
Assignee: nobody → blassey.bugs
Attachment #455056 - Flags: review?(mark.finkle)
Comment on attachment 455056 [details] [diff] [review]
patch

Remove the entry in makefiles.sh

http://mxr.mozilla.org/mobile-browser/source/makefiles.sh#50
Attachment #455056 - Flags: review?(mark.finkle) → review+
this was pushed:
http://hg.mozilla.org/mobile-browser/rev/a110500c760d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
There is a problem with android builds that blocks testing on android devices: bug 589808

Otherwise this is verified FIXED on Maemo build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b4pre) Gecko/20100823 Namoroka/4.0b4pre Fennec/2.0a1pre
(In reply to comment #4)
> There is a problem with android builds that blocks testing on android devices:
> bug 589808
> 
> Otherwise this is verified FIXED on Maemo build:
> 
> Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b4pre)
> Gecko/20100823 Namoroka/4.0b4pre Fennec/2.0a1pre

given bug 589808 is wfm, marking this verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.