57544 - Reproducable segfault when loading text file over HTTP

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect, P3)

Description

[Aaron Lehmann]

The following will segfault Skipstone, Galeon, and TestGtkEmbed:

Go to a HTTP file listing (e.g. http://incoming.debian.org), click on any text
file (e.g. anything ending in .dsc or .changes). The URL field will not change,
and the back button will not be activated. If you press enter in the unchanged
URL field, there will be a segfault, even if you first change the text of the
URL field to something completely different.

Version: CVS mozilla as of 10/21/00

Comment 1

[Stuart Parmenter]

-> blizzard

Comment 2

[Christopher Blizzard (:blizzard)]

The fix here is to add text/plain to the list of supported flavors in the
nsIURIContentListener::IsPreferred() method.  However, this is pretty scary
because it means that if you return a denial from that method it still loads it
and puts the docshell into an unusable state.

Still looking for a review to fix the crash in the meantime.  Can you guys have
a quick look at this?  The patch below is in
embedding/browser/gtk/src/GtkMozEmbedChrome.cpp in the IsPreferred() method.
It's mixed in with a lot of other patches which is why it looks like this.

   {
     PR_LOG(mozEmbedLm, PR_LOG_DEBUG, ("checking content type %s\n", aContentTyp
e));
     if (nsCRT::strcasecmp(aContentType,  "text/html") == 0
+       || nsCRT::strcasecmp(aContentType, "text/plain") == 0
         || nsCRT::strcasecmp(aContentType, "text/xul") == 0
         || nsCRT::strcasecmp(aContentType, "text/rdf") == 0
         || nsCRT::strcasecmp(aContentType, "text/xml") == 0

Comment 3

[Christopher Blizzard (:blizzard)]

Can someone review this change?  A lot of people are running into this problem
and I'd like to get a fix in until we fix the larger issue.

Comment 4

[Judson Valeski]

r=valeski

Comment 5

[Brendan Eich [:brendan]]

I think mscott or rpotts should super-review.

/be

Comment 6

[Scott MacGregor]

I'm cool with adding text/plain to this method.

sr=mscott

Comment 7

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks, guys.