use an existing makedirs function

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Jeff Hammel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-2.0+])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
makedirs is redefined in mozrunner:

http://github.com/mozautomation/mozmill/blob/master/mozrunner/mozrunner/__init__.py#L148

instead, os.makedirs may be used
(Reporter)

Updated

7 years ago
OS: Linux → All
Hardware: x86 → All
Whiteboard: [mozmill-2.0?]
(Reporter)

Comment 1

7 years ago
Created attachment 501509 [details] [diff] [review]
remove hand-rolled makedirs function

works for linux.  untested on mac + win
Attachment #501509 - Flags: review?(fayearthur+bugs)
Comment on attachment 501509 [details] [diff] [review]
remove hand-rolled makedirs function

works on Mac too.
Attachment #501509 - Flags: review?(fayearthur+bugs) → review+

Updated

7 years ago
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
(Reporter)

Comment 3

7 years ago
pushed to master: https://github.com/mozautomation/mozmill/commit/b2a88695c8bda91f02456ad110205507d49e45c7

There has been some talk that os.makedirs does not work for some cases.  Of course, this is impossible to tell since there is no comment to that affect.  If there is a reason to revert, we can revert or use e.g. distutils.dir_util.create_tree . If we do add it back in, we should have at least a comment and preferably a test and it should probably be rewritten in a more reasonable manner (with, again, any subtleties documented)
(Reporter)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.