575493 - When maximized, aero glass drag effects don't extend to the screen edge (window tear off)

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[imradyurrad]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre

Double click on the top of the window when maxmimized - nothing happens
Try to draw the window down - nothing happens.

Reproducible: Always

Comment 1

[Benjamin Xiao]

You mean drag the window down right?

But yes I can confirm that this happens on my Windows 7 machine as well.

Comment 2

[[not reading bugmail]]

Do you have the App Menu button or the Menu bar?  It should be working.. It works on the most current hourly.

Comment 3

[Jim Mathies [:jimm]]

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100628 Firefox/3.6.4 ( .NET CLR 3.5.30729; .NET4.0C)

WFM

Comment 4

[Jim Mathies [:jimm]]

Any extensions installed that might intercepting mouse clicks up top?

Comment 5

[imradyurrad]

(In reply to comment #1)
> You mean drag the window down right?
> 
> But yes I can confirm that this happens on my Windows 7 machine as well.

Yes I meant drag.


(In reply to comment #2)
> Do you have the App Menu button or the Menu bar?  It should be working.. It
> works on the most current hourly.

With the app button enabled, the aero doesn't extend to window

(In reply to comment #4)
> Any extensions installed that might intercepting mouse clicks up top?

Nope. 
http://img541.imageshack.us/img541/9168/clipboard01dk.jpg
And I don't have any userstyles installed.

Comment 6

[[not reading bugmail]]

What about greasemonkey?  

(In reply to comment #5)
> With the app button enabled, the aero doesn't extend to window

And your mouse settings are default double click speed, and assignment?

Comment 7

[infinite.luta]

Mozilla/5.0 (Windows; U; Windows NT 6.1; Win64; x64; en-US; rv:1.9.3a6pre) Gecko/20100628 Minefield/3.7a6pre

Works for me using the current Win64 nightly on Windows 7.

Double clicking the titlebar: Window is restored
Dragging the titlebar down: Window is restored

Comment 8

[[not reading bugmail]]

Please try in safe mode with a new profile.

Comment 9

[imradyurrad]

(In reply to comment #6)
> What about greasemonkey?  
> 
> (In reply to comment #5)
> > With the app button enabled, the aero doesn't extend to window
> 
> And your mouse settings are default double click speed, and assignment?

Yes. And with all addons disabled, it still persists.

(In reply to comment #7)
> Mozilla/5.0 (Windows; U; Windows NT 6.1; Win64; x64; en-US; rv:1.9.3a6pre)
> Gecko/20100628 Minefield/3.7a6pre
> 
> Works for me using the current Win64 nightly on Windows 7.
> 
> Double clicking the titlebar: Window is restored
> Dragging the titlebar down: Window is restored

I'm using the latest hourly and I've already tried it with a new profile in safemode with everything disabled.

Comment 10

[[not reading bugmail]]

Does your mouse ever get stuck on when trying to resize? I haven't seen that and then other issues like this happen.  I have to use the task manager sometimes to kill it.. not often.  

That's about the only other thing I can think of, unless you want to try to uninstall minefield to remove the folder, and reinstall it to see if that helps.

Comment 11

[[not reading bugmail]]

(In reply to comment #10)
> Does your mouse ever get stuck on when trying to resize? I haven't seen that
> and then other issues like this happen.  I have to use the task manager
> sometimes to kill it.. not often.  

s/haven't/have/

Comment 12

[Benjamin Xiao]

No it only stops working on the very top pixel of a maximized Firefox window. This only ocurs with Minefield button, not menu bar.

So basically maximize Firefox window, hit your mouse cursor against the top of your screen, and try to drag the window away. It will not work. But if you move just one pixel down and then drag, it works.

Comment 13

[[not reading bugmail]]

(In reply to comment #12)
> No it only stops working on the very top pixel of a maximized Firefox window.
> This only ocurs with Minefield button, not menu bar.
> 
> So basically maximize Firefox window, hit your mouse cursor against the top of
> your screen, and try to drag the window away. It will not work. But if you move
> just one pixel down and then drag, it works.

Jim, confirming.. I see this now, thanks for STR, this is a bug, but blocking the wrong it looks like.

Comment 14

[imradyurrad]

(In reply to comment #12)
> No it only stops working on the very top pixel of a maximized Firefox window.
> This only ocurs with Minefield button, not menu bar.
> 
> So basically maximize Firefox window, hit your mouse cursor against the top of
> your screen, and try to drag the window away. It will not work. But if you move
> just one pixel down and then drag, it works.

Perfect description.

Comment 15

[Jim Mathies [:jimm]]

this is in the testResult coordinate math in hit testing. should be easy to fix, low priority though.

Comment 17

[imradyurrad]

(In reply to comment #15)
> this is in the testResult coordinate math in hit testing. should be easy to
> fix, low priority though.

I don't see how it's low priority. What's the use of including aero effects if they don't fully work? And as far as I know, users usually just bounce their cursor to the edge of the screen. I don't think anyone specifically finds an area 2px below the edge to use the effects. 

Just my opinion.

Comment 20

[Jim Mathies [:jimm]]

Attachment: fix

Comment 21

[Rob Arnold [:robarnold]]

Comment on attachment 455195 [details] [diff] [review]
fix

This seems to fix the problem and I didn't spot any regressions.

Comment 22

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/fb46b4128935

Comment 24

[[not reading bugmail]]

V. Fixed with recent nightly

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100701 Minefield/4.0b2pre