575517 - Optional jsvals that are not specified should be JSVAL_VOID, not JSVAL_NULL

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

PConnect makes optional jsvals JSVAL_NULL currently even though JSVAL_VOID is a better choice. Simple patch to fix.

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 454780 [details] [diff] [review]
Patch, v1

+            if(i < mArgc)
+                src = mArgv[i];
+            else if (type_tag == nsXPTType::T_JSVAL)

Remove the space between if and '(' to be consistent with the rest of this code...

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/665b3c7b414a