575575 - Error in regression test (mozilla/data/js1_5/Array/regress-465980-02.js)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Rico]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/533.4 (KHTML, like Gecko) Chrome/5.0.375.86 Safari/533.4
Build Identifier: 

The test uses the uninitialized index variable in line 166, I will attach a patch to the bug after filing it.

Reproducible: Always

Steps to Reproduce:
1. Run the test with input that causes this line to get executed
2.
3.
Actual Results:  
Can't lookup index

Expected Results:  
That is expected, since it is not defined.

Comment 1

[Rico]

Attachment: Patch to fix test

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 454829 [details] [diff] [review]
Patch to fix test

http://hg.mozilla.org/tracemonkey/rev/e13ca0224e02

Thanks for pointing out the problem, have pushed the fix.

In the future, if you don't mind, we prefer unified-format patches with some context to them -- line 166 plus file name (which, it's worth noting, isn't in the patch itself) identifies the correct location, but it's impossible to say, just from the patch, that it's actually correct.  I had to pull up the test file to double-check the variable actually wasn't defined.  Everything worked out fine in the end here, just the difference between good and awesome.  :-)

Comment 3

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/e13ca0224e02