Closed
Bug 575638
Opened 15 years ago
Closed 14 years ago
[e10s] clarify gChromeRegistry usage in nsChromeRegistry.cpp
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | - | --- |
People
(Reporter: dougt, Unassigned)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
dougt
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
>+++ b/chrome/src/nsChromeRegistry.cpp
>+nsChromeRegistry::GetService()
>..
>+ if (!nsChromeRegistry::gChromeRegistry)
Why the qualifier?
>+ NS_IF_ADDREF(gChromeRegistry);
Can't be null there.
|
||
Comment 1•14 years ago
|
||
Attachment #459924 -
Flags: review?(doug.turner)
|
Reporter | |
Updated•14 years ago
|
Attachment #459924 -
Flags: review?(doug.turner) → review+
|
||
Updated•14 years ago
|
tracking-fennec: --- → ?
|
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 459924 [details] [diff] [review]
patch
very low risk (if it compiles, it should be good to go)
follow up bug on the e10s -> mc landing.
Attachment #459924 -
Flags: approval2.0+
|
|
Reporter | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 4•14 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•