Closed Bug 575638 Opened 13 years ago Closed 13 years ago

[e10s] clarify gChromeRegistry usage in nsChromeRegistry.cpp

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fennec - ---

People

(Reporter: dougt, Unassigned)

References

Details

Attachments

(1 file)

patch
1.02 KB, patch
dougt
: review+
dougt
: approval2.0+
Details | Diff | Splinter Review 
>+++ b/chrome/src/nsChromeRegistry.cpp
>+nsChromeRegistry::GetService()
>..
>+  if (!nsChromeRegistry::gChromeRegistry)

Why the qualifier?

>+  NS_IF_ADDREF(gChromeRegistry);

Can't be null there.
Attached patch patch — — Splinter Review 

        Attachment #459924 -
        Flags: review?(doug.turner)

    
  

        Attachment #459924 -
        Flags: review?(doug.turner) → review+
tracking-fennec: --- → ?

    
    

    
  
would not block shipping fennec on this.
tracking-fennec: ? → 2.0-

    
    

    
  
Comment on attachment 459924 [details] [diff] [review]
patch

very low risk (if it compiles, it should be good to go)

follow up bug on the e10s -> mc landing.

        Attachment #459924 -
        Flags: approval2.0+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/66ddd173c442
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.