>+ _width = nsPresContext::AppUnitsToIntCSSPixels(w); >+ _height = nsPresContext::AppUnitsToIntCSSPixels(h); Really? If the args are app units, shouldn't they be nscoord instead of PRInt32? This seems to apply throughout here. Should there be sanity checks for negative w and h here?
http://mxr.mozilla.org/mozilla-central/source/content/canvas/src/DocumentRendererChild.cpp#131 cjones, is negative w and h an issue?
Sorry, missed this comment yesterday. We'd probably hit a cairo assertion for negative w/h and get back an invalid cairo surface, but this is dead code walking so I'm not sure how much we care.
chris, should we just wontfix
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.