Closed Bug 575650 Opened 14 years ago Closed 14 years ago

[e10s] use NS_NOTREACHED in WebGLContext to safe-guard callers

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
fennec - ---

People

(Reporter: dougt, Unassigned)

References

Details

>+++ b/content/canvas/src/WebGLContext.h
>+    NS_IMETHOD Swap(mozilla::ipc::Shmem& aBack,
>+                    PRInt32 x, PRInt32 y, PRInt32 w, PRInt32 h)
>+                    { return NS_ERROR_NOT_IMPLEMENTED; }
>+    NS_IMETHOD Swap(PRUint32 nativeID,
>+                    PRInt32 x, PRInt32 y, PRInt32 w, PRInt32 h)
>+                    { return NS_ERROR_NOT_IMPLEMENTED; }

Callers ignore the retval.  Should these be NS_NOTREACHED for good measure?
tracking-fennec: --- → ?
vlad - is this an issue?
I have no idea, I don't know the IPC api at all.  All this ipc stuff from canvas rendering contexts should be going away very soon though (maybe even right now?)
tracking-fennec: ? → 2.0-
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.