Closed Bug 575652 Opened 11 years ago Closed 11 years ago

[e10s] inline DeallocShmem setup

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
fennec - ---

People

(Reporter: dougt, Assigned: MikeK)

References

Details

Attachments

(1 file)

>+    ContentProcessParent* allocator = ContentProcessParent::GetSingleton(PR_FALSE);
>+    if (allocator && gfxSharedImageSurface::IsSharedImage(mBackSurface)) {
>+        Shmem mem = static_cast<gfxSharedImageSurface*>(mBackSurface.get())->GetShmem();
>+        allocator->DeallocShmem(mem);
>+    }

Would be good to not have two copies of that code.  Inline function or macro,
please?
Summary: [e10s] inline DeallocShmem. → [e10s] inline DeallocShmem setup
tracking-fennec: --- → ?
not blocking fennec on this.
tracking-fennec: ? → 2.0-
Assignee: nobody → mkristoffersen
Status: NEW → ASSIGNED
Attachment #484997 - Flags: review?(doug.turner)
Attachment #484997 - Flags: review?(doug.turner) → review?(jones.chris.g)
Comment on attachment 484997 [details] [diff] [review]
Inline function created

OK, but just to warn you, after bug 590525 or fast -moz-element, this shmem canvas code is going to be deleted.
Attachment #484997 - Flags: review?(jones.chris.g) → review+
Comment on attachment 484997 [details] [diff] [review]
Inline function created

low risk, cleans up bz's comments.
Attachment #484997 - Flags: approval2.0+
Pushed: http://hg.mozilla.org/mozilla-central/rev/f3ae8be93235
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.