[e10s] inline DeallocShmem setup

RESOLVED FIXED in mozilla2.0b7

Status

()

Core
IPC
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dougt, Assigned: MikeK)

Tracking

(Blocks: 1 bug)

unspecified
mozilla2.0b7
Points:
---

Firefox Tracking Flags

(fennec-)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
>+    ContentProcessParent* allocator = ContentProcessParent::GetSingleton(PR_FALSE);
>+    if (allocator && gfxSharedImageSurface::IsSharedImage(mBackSurface)) {
>+        Shmem mem = static_cast<gfxSharedImageSurface*>(mBackSurface.get())->GetShmem();
>+        allocator->DeallocShmem(mem);
>+    }

Would be good to not have two copies of that code.  Inline function or macro,
please?
(Reporter)

Updated

8 years ago
Summary: [e10s] inline DeallocShmem. → [e10s] inline DeallocShmem setup
tracking-fennec: --- → ?
(Reporter)

Comment 1

8 years ago
not blocking fennec on this.
tracking-fennec: ? → 2.0-
(Assignee)

Comment 2

8 years ago
Created attachment 484997 [details] [diff] [review]
Inline function created
Assignee: nobody → mkristoffersen
Status: NEW → ASSIGNED
Attachment #484997 - Flags: review?(doug.turner)
(Reporter)

Updated

8 years ago
Attachment #484997 - Flags: review?(doug.turner) → review?(jones.chris.g)
Comment on attachment 484997 [details] [diff] [review]
Inline function created

OK, but just to warn you, after bug 590525 or fast -moz-element, this shmem canvas code is going to be deleted.
Attachment #484997 - Flags: review?(jones.chris.g) → review+
(Reporter)

Comment 4

8 years ago
Comment on attachment 484997 [details] [diff] [review]
Inline function created

low risk, cleans up bz's comments.
Attachment #484997 - Flags: approval2.0+
Pushed: http://hg.mozilla.org/mozilla-central/rev/f3ae8be93235
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.