Closed
Bug 575652
Opened 14 years ago
Closed 14 years ago
[e10s] inline DeallocShmem setup
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| fennec | - | --- |
People
(Reporter: dougt, Assigned: MikeK)
References
Details
Attachments
(1 file)
|
2.82 KB,
patch
|
cjones
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
>+ ContentProcessParent* allocator = ContentProcessParent::GetSingleton(PR_FALSE);
>+ if (allocator && gfxSharedImageSurface::IsSharedImage(mBackSurface)) {
>+ Shmem mem = static_cast<gfxSharedImageSurface*>(mBackSurface.get())->GetShmem();
>+ allocator->DeallocShmem(mem);
>+ }
Would be good to not have two copies of that code. Inline function or macro,
please?
|
Reporter | |
Updated•14 years ago
|
Summary: [e10s] inline DeallocShmem. → [e10s] inline DeallocShmem setup
|
||
Updated•14 years ago
|
tracking-fennec: --- → ?
|
Assignee | |
Comment 2•14 years ago
|
||
Assignee: nobody → mkristoffersen
Status: NEW → ASSIGNED
Attachment #484997 -
Flags: review?(doug.turner)
|
|
Reporter | |
Updated•14 years ago
|
Attachment #484997 -
Flags: review?(doug.turner) → review?(jones.chris.g)
Comment on attachment 484997 [details] [diff] [review] Inline function created OK, but just to warn you, after bug 590525 or fast -moz-element, this shmem canvas code is going to be deleted.
Attachment #484997 -
Flags: review?(jones.chris.g) → review+
|
|
Reporter | |
Comment 4•14 years ago
|
||
Comment on attachment 484997 [details] [diff] [review] Inline function created low risk, cleans up bz's comments.
Attachment #484997 -
Flags: approval2.0+
|
||
Comment 5•14 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/f3ae8be93235
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•