[e10s] ipc config includes

RESOLVED WORKSFORME

Status

()

Core
IPC
RESOLVED WORKSFORME
8 years ago
4 years ago

People

(Reporter: dougt, Assigned: Jae-Seong Lee-Russo)

Tracking

(Blocks: 1 bug)

unspecified
Points:
---

Firefox Tracking Flags

(e10s+, fennec-)

Details

(Whiteboard: not-ready)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
ted,

when we added the following to the build system, bz raised the following concern:

>diff --git a/dom/base/Makefile.in b/dom/base/Makefile.in
>+ifdef MOZ_IPC
>+include $(topsrcdir)/config/config.mk
>+include $(topsrcdir)/ipc/chromium/chromium-config.mk
>+endif

The other includes of chromium-config.mk didn't ifdef MOZ_IPC it.  Which is the
right way?


Do you know if it is safe or wanted to include those config files when MOZ_IPC is off?
I have no idea, you want to ask bsmedberg or cjones.

Comment 2

8 years ago
chromium-config already has MOZ_IPC ifdefs, you don't need to repeat them.
(Assignee)

Comment 3

8 years ago
Created attachment 459922 [details] [diff] [review]
patch
Attachment #459922 - Flags: review?(doug.turner)
(Reporter)

Updated

8 years ago
Attachment #459922 - Flags: review?(doug.turner) → review+
tracking-fennec: --- → ?
(Reporter)

Comment 4

7 years ago
not blocking fennec on this.
tracking-fennec: ? → 2.0-
(Reporter)

Updated

7 years ago
Attachment #459922 - Flags: approval2.0?
Assignee: nobody → lusian

Updated

7 years ago
Attachment #459922 - Flags: approval2.0? → approval2.0+

Comment 5

7 years ago
Comment on attachment 459922 [details] [diff] [review]
patch

Not landed yet, too late for this release.
Attachment #459922 - Flags: approval2.0+ → approval2.0-

Comment 6

7 years ago
This patch doesn't apply cleanly any more.
Whiteboard: not-ready
tracking-e10s: --- → +
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.