ted, when we added the following to the build system, bz raised the following concern: >diff --git a/dom/base/Makefile.in b/dom/base/Makefile.in >+ifdef MOZ_IPC >+include $(topsrcdir)/config/config.mk >+include $(topsrcdir)/ipc/chromium/chromium-config.mk >+endif The other includes of chromium-config.mk didn't ifdef MOZ_IPC it. Which is the right way? Do you know if it is safe or wanted to include those config files when MOZ_IPC is off?
I have no idea, you want to ask bsmedberg or cjones.
chromium-config already has MOZ_IPC ifdefs, you don't need to repeat them.
Created attachment 459922 [details] [diff] [review] patch
Attachment #459922 - Flags: review?(doug.turner)
Attachment #459922 - Flags: review?(doug.turner) → review+
not blocking fennec on this.
tracking-fennec: ? → 2.0-
Assignee: nobody → lusian
Comment on attachment 459922 [details] [diff] [review] patch Not landed yet, too late for this release.
Attachment #459922 - Flags: approval2.0+ → approval2.0-
This patch doesn't apply cleanly any more.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.