57580 - [FIX][MF][LST]Can still select disabled listbox items

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Blake Ross]

Build ID: new trunk

Steps to Reproduce:

(1) Debug > Viewer Demos > #8 Form (resource:///res/samples/test8.html)
(2) Scroll down to where it says "Disabled Option Test"
(3) In the "Select size=4 with Disabled option (Listbox)" listbox, click the 
disabled "Two" item.  It doesn't get selected, as expected.
(4) Now select the "One" item and drag downwards, with the left mouse button 
still down.

Result: You can still select the "Two" item while the mouse button is down.  
Desirable behavior is that selection passes right over that item and goes to 
the next non-disabled (enabled) item, as if the disabled item(s) wasn't even 
there, and as we do in <optgroup> labels.

Comment 1

[rods (gone)]

I thought I fixed this too....

Comment 2

[rods (gone)]

*** Bug 57583 has been marked as a duplicate of this bug. ***

Comment 3

[rods (gone)]

Simple fix, all I have to do is remove a line that shouldn't be there.

Patch:

Index: nsListControlFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/forms/src/nsListControlFrame.cpp,v
retrieving revision 1.170
diff -u -r1.170 nsListControlFrame.cpp
--- nsListControlFrame.cpp	2000/10/28 22:14:50	1.170
+++ nsListControlFrame.cpp	2000/12/18 19:55:56
@@ -2895,7 +3051,6 @@
       mButtonDown = PR_FALSE;
       CaptureMouseEvents(mPresContext, PR_FALSE);
       SetContentSelected(mSelectedIndex, PR_FALSE);
-      mSelectedIndex = kNothingSelected;
       return NS_OK;
     }
   }

Comment 4

[buster]

sr=buster

Comment 5

[Blake Ross]

r=blake

Comment 6

[rods (gone)]

Fixed

Comment 7

[Blake Ross]

Still broken for me with the patch...(?)

Comment 8

[rods (gone)]

Blake, you were right. The fix I just checked in fixed 57583, but this bug. I 
didn't read it close enough about the "drag" part, my fault. Bummer.

Here is the patch that fixes both:
Index: nsListControlFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/forms/src/nsListControlFrame.cpp,v
retrieving revision 1.171
diff -u -r1.171 nsListControlFrame.cpp
--- nsListControlFrame.cpp	2000/12/18 21:36:01	1.171
+++ nsListControlFrame.cpp	2000/12/18 23:22:51
@@ -2890,11 +2890,13 @@
       if (IsInDropDownMode() == PR_TRUE && mComboboxFrame) {
         ResetSelectedItem();
         mComboboxFrame->ListWasSelected(mPresContext, PR_FALSE); 
-      } 
+      } else {
+        SetContentSelected(mSelectedIndex, PR_FALSE);
+        mSelectedIndex = kNothingSelected;
+      }
       REFLOW_DEBUG_MSG(">>>>>> Option is disabled");
       mButtonDown = PR_FALSE;
       CaptureMouseEvents(mPresContext, PR_FALSE);
-      SetContentSelected(mSelectedIndex, PR_FALSE);
       return NS_OK;
     }
   }


The bottom line here is the line I removed with the last patch still needed to 
be there. But that line plus SetContentSelected line needed to only be executed 
when it wasn't in dropdown mode.

I probably added those two lines in to fix ListBoxes and didn't realize I was 
breaking comboboxes. So now they are both fixed.

Comment 9

[Kevin McCluskey (gone)]

Patch looks good.
r=[e-mail]

Comment 10

[rods (gone)]

fixed

Comment 11

[Loco]

VERIFIED using Mac 12-22-12 and Linux 12-19-08.

Comment 12

[Blake Ross]

This still isn't fixed.  I think I may have been unclear in my original report 
(because this isn't really a MUSTFIX issue)...

Comment 13

[rods (gone)]

Attachment: reduced testcase

Comment 14

[rods (gone)]

The only bug I can find with this, is if I hit the letter "T" in either list it 
will go to the disabled "Two" item. And I think this is a must fix.

Comment 15

[rods (gone)]

Attachment: patch for pressing first letter and it going to disabled item

Comment 16

[buster]

sr=buster

Comment 17

[Kevin McCluskey (gone)]

r=[e-mail]

Comment 18

[rods (gone)]

I need to check this in

Comment 19

[Kevin McCluskey (gone)]

Setting milestone to mozilla0.8.1

Comment 20

[Vladimir Ermakov]

QA Contact Update

Comment 21

[rods (gone)]

fixed

Comment 22

[rods (gone)]

try this again - fixed

Comment 23

[Vladimir Ermakov]

Verifying on build 2001-03-29-04-Mtrunk

Comment 24

[Blake Ross]

/me bangs head against the wall

This isn't fixed!  The bug is that the item still selects if you mouse down on, 
say, an item above it and move the cursor downwards while holding the 
mousebutton.  A minor bug, sure, but it still exists ;-)

Feel free to bother Ian if you need further explanation of it.

Comment 25

[Luis Reis]

Should this be retargeted for 0.9 ???

Comment 26

[rods (gone)]

On 1/3/01 I asked for an explanation for what was wrong and couldn't figure 
it out. Ok, now I know what else to fix.

Futuring

Comment 27

[John Keiser (jkeiser)]

This has been fixed.

Comment 28

[John Keiser (jkeiser)]

(Bug 34297 was the one that fixed it.)

Comment 29

[Vladimir Ermakov]

Verifying on build 20020807