Closed Bug 575809 Opened 14 years ago Closed 14 years ago

Leak fix: remove all pending tasks from queue

Categories

(Toolkit :: Places, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: stechz, Unassigned)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
When Firefox exits abruptly, be sure to drop references to remaining tasks.
Attachment #454986 - Flags: review?(sdwilsh)
Comment on attachment 454986 [details] [diff] [review]
patch

I missed this before, but .Push returns something that we don't use, so we should be casting to (void).  Please fix that in this file.

>+  // History is going away, so abandon tasks.
>+  while (mPendingVisits.PeekFront()) {
>+    nsCOMPtr<Step> deadTaskWalking =
>+      dont_AddRef(static_cast<Step*>(mPendingVisits.PopFront()));
>+  }
I feel like we should give a warning here that things are not done.  This could be data loss (last page not saved), right?

Shame we can't use Empty or Erase here.

r=sdwilsh
Attachment #454986 - Flags: review?(sdwilsh) → review+
Patch was backed out, will merge this fix in with bug 556400.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: